Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Nginx: Allow to specify listen options #1831

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JulesdeCube
Copy link

Motivation

All OneUptime's services are now ipv6 friendly except Nginx that still listen only on IPv4. This PR finish the work done on #1773 and #1807.

Description

This PR allow to modify nginx's listen address and options to be able to listen on dual and ipv6 only network stack.

It introduce the NGINX_LISTEN_ADDRESS and NGINX_LISTEN_OPTIONS environmental variable inside the nginx configuration template so modify both parameter.

This PR don't change the current behaviors.

Example

IPv6 only:

NGINX_LISTEN_ADDRESS=[::]:
NGINX_LISTEN_OPTIONS=

dual stack:

NGINX_LISTEN_ADDRESS=[::]:
NGINX_LISTEN_OPTIONS=ipv6only=off

Pull Request Checklist:

  • Please make sure all jobs pass before requesting a review.
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
  • Have you lint your code locally before submission?
  • Did you write tests where appropriate?

Related Issues

#1348
#1773
#1807

@simlarsen
Copy link
Contributor

Correct me if I'm wrong, but I believe you need to have these env var in docker-compose, config.env, helpers.tpl etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants