Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move setting of Save context flags from Patches to Savecontext #2367

Open
wants to merge 1 commit into
base: Dev
Choose a base branch
from

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Jan 24, 2025

Another PR with the goal of cleaning Patches.py a tiny bit.
Instructions that write initial save context flags have been regrouped and divided in two functions moved in SaveContext.py :

  • write_qol_save_context_flags, which are currently always on whatever the settings chosen. Since they don't use any other data, this can be a member of SaveContext.
  • write_settings_dependent_save_context_flags for the rest, in a function separate of the class.

I chose to let a couple of these flags in Patches.py if they were part of a bigger code block for their specific settings, since i felt it would make it less readable if that flag was set somewhere else.

This should be strictly indentical in behaviour, barring of course any mistake.

@GSKirox GSKirox added Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Status: Under Consideration Developers are considering whether to accept or decline the feature described Component: Patching Affects the patching of the ROM Type: Maintenance Code style, infrastructure, updating dependencies labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Patching Affects the patching of the ROM Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Status: Under Consideration Developers are considering whether to accept or decline the feature described Type: Maintenance Code style, infrastructure, updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant