-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-layer Perceptron classifier #493
base: ml
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small notes
"name": "activation_function", | ||
"description": "Activation function for the hidden layers.", | ||
"schema": { | ||
"type": "string", | ||
"enum": [ | ||
"relu", | ||
"tanh", | ||
"sigmoid" | ||
], | ||
"default": "relu" | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might need some minor corrections. We cannot specify a specific activation function per layer. A choice might be more appropriate
- a single string: activation function applied to all layers
- an array of strings: one string to specify the activation function for each layer
It might also be helpful to include softmax
here, commonly used on the output layer, helpful for uncertainty quantification.
This could be the schema
then:
{
"oneOf": [
{
"type": "string",
"enum": ["relu", "tanh", "sigmoid", "softmax"]
},
{
"type": "array",
"items": {
"type": "string",
"enum": ["relu", "tanh", "sigmoid", "softmax"]
}
}
],
"default"="relu"
}
} | ||
}, | ||
{ | ||
"name": "hidden_layers", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We define the shape of hidden layers here. But where do we define the shape of input and output layers?
Suggestion: Rename this parameter to layers
to include input and output.
"deep learning" | ||
], | ||
"experimental": true, | ||
"parameters": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be helpful to somehow divide training data into train/test to get training statistics independently from the training data, e.g.
{
"name": "train_test_split",
"description": "defines the ration by which data is split into training and test samples",
"schema": {
"type": "number",
"minimum": 0.0,
"maximum": 1.0,
"default": 0.8
}
}
No description provided.