Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] remove option to remove dynamic asset from asset group (#2434) #2437

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

antoinemzs
Copy link
Contributor

@antoinemzs antoinemzs commented Feb 11, 2025

Proposed changes

  • Dynamic assets don't have an option to be removed from asset groups that define a filter that incliuded said asset

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Known remaining issues

  • Possible to manually add asset that is already part of the asset group dynamically

@antoinemzs antoinemzs changed the base branch from master to release/current February 11, 2025 15:27
Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs antoinemzs changed the title [frontend] remove option to remove dynmaic asset from asset group (#2434) [frontend] remove option to remove dynamic asset from asset group (#2434) Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.26%. Comparing base (7c39b58) to head (1c3f0d9).
Report is 5 commits behind head on release/current.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #2437      +/-   ##
=====================================================
- Coverage              38.29%   38.26%   -0.03%     
- Complexity              1809     1811       +2     
=====================================================
  Files                    598      598              
  Lines                  18403    18430      +27     
  Branches                1230     1231       +1     
=====================================================
+ Hits                    7047     7052       +5     
- Misses                 10971    10990      +19     
- Partials                 385      388       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Antoine MAZEAS <[email protected]>
@MarineLeM MarineLeM self-requested a review February 11, 2025 16:06
}, [endpointIds]);

const isLoading = loading && endpointIds.length > 0;

return (
<>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With your modification, you don't need this tags anymore

Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs antoinemzs requested a review from MarineLeM February 11, 2025 17:47
@antoinemzs antoinemzs merged commit 22e46c8 into release/current Feb 12, 2025
6 checks passed
@antoinemzs antoinemzs deleted the 2434/remove_option_on_filter_assets branch February 12, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable remove from asset group controls for assets included by filter
3 participants