Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix obb.news.company(provider="yfinance") #7003

Merged
merged 2 commits into from
Jan 13, 2025
Merged

[BugFix] Fix obb.news.company(provider="yfinance") #7003

merged 2 commits into from
Jan 13, 2025
+1,308 −679

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented Jan 10, 2025 •
edited
Loading

  1. Why?:

    • Fixes the failing test highlighted here
    • The response object has changed dramatically.

  2. What?:

    • Remaps items to new keys from the raw data.
    • Bumps the version of yFinance to 0.2.51
    • Recaptures test cassettes.

  3. Impact:

    • Fixes a broken function, unit tests did their job.

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Jan 10, 2025
@deeleeramone deeleeramone added this pull request to the merge queue Jan 13, 2025
Merged via the queue into develop with commit 58b252c Jan 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeleeramone @IgorWounds