fix: unintentional change of background color

- fixed regression - initialization of the black scene caused unintentional switch to dark background during startup
OpenBoard-org · Sep 5, 2024 · e1a7403 · e1a7403
1 parent 7c8bba5
commit e1a7403
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/domain/UBGraphicsScene.cpp b/src/domain/UBGraphicsScene.cpp
@@ -1130,14 +1130,12 @@ void UBGraphicsScene::setSceneBackground(bool pIsDark, const UBBackgroundRuling
         updatePenCircleColor();
         recolorAllItems();
 
-        UBSettings::settings()->setDarkBackground(mDarkBackground);
         needRepaint = true;
     }
 
     if (mBackground != background)
     {
         mBackground = background;
-        UBSettings::settings()->setPageBackgroundUuid(mBackground ? mBackground->uuid() : QUuid{});
         needRepaint = true;
     }
 

diff --git a/src/gui/UBBackgroundPalette.cpp b/src/gui/UBBackgroundPalette.cpp
@@ -235,7 +235,7 @@ void UBBackgroundPalette::defaultBackgroundGridSize()
 void UBBackgroundPalette::toggleBackgroundColor(bool checked)
 {
     mIsDark = checked;
-    UBApplication::boardController->activeScene()->setSceneBackground(mIsDark, mBackground);
+    UBApplication::boardController->setBackground(mIsDark, mBackground);
     backgroundChanged();
 }
 
@@ -249,7 +249,7 @@ void UBBackgroundPalette::changeBackground(bool checked)
         {
             const auto uuid = action->property("uuid").toUuid();
             mBackground = UBApplication::boardController->backgroundManager()->background(uuid);
-            UBApplication::boardController->activeScene()->setSceneBackground(mIsDark, mBackground);
+            UBApplication::boardController->setBackground(mIsDark, mBackground);
         }
     }
 }