feat: User-defined podcast fps #1232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the podcast recording is set to a fixed 10 fps. While there exists a setting to allow for customisation, it remains unused. This change takes the user setting into account. The actual fps are determined by the activity on the board, so it represents a maximum fps. This value is further refined depending on the selected podcast preset: - Full: Use the value directly - Medium: The max. fps are halved - Small: The max. fps are divided by 4 The default has been bumped up to 100 fps. This value is never actually reached - the resulting fps hover mostly around 40-70. During testing on my rather powerful machine (with values exceeding 250 fps), the observed frame rate never got appreciably higher than 100 fps (maximum was 127 fps for short periods at 1000). Thus, the Full preset in its default configuration captures all activity. Choosing a lower preset decreases the fps accordingly, with 25 fps at the lower end of what is perceived as fluid motion, though actual framerate can be around 12-18. Further tuning is possible via the "Podcast->FramesPerSecond" setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the podcast recording is set to a fixed 10 fps. While there exists a setting to allow for customisation, it remains unused.
This change takes the user setting into account. The actual fps are determined by the activity on the board, so it represents a maximum fps. This value is further refined depending on the selected podcast preset:
The default has been bumped up to 100 fps. During testing, I mostly got 40-70 fps in the resulting video. I don't know where the discrepancy comes from, but even setting it to a ridiculous 1000 only achieved like 127 fps peak. For highest quality I'd probably set it to 250 or 300.
For the Small preset, the default setting is 25, which is at the lower limit of what is perceived as fluid motion. In high activity scenes, it's around 12-18, though I regularly hit the 25. If bandwidth or CPU power needs to be saved, the default can be lowered further.
In moments of low activity, all values can go down to 8-10 fps. The horologe produces consistently 20fps.
In conclusion, I believe that this change improves the podcast experience.
Solves #991 #106