Skip to content

Commit

Permalink
refactor(collections): optimize empty data display logic (#841)
Browse files Browse the repository at this point in the history
  • Loading branch information
youngbeom-shin authored Dec 12, 2024
1 parent ce9300d commit 2fe84fb
Showing 1 changed file with 4 additions and 32 deletions.
36 changes: 4 additions & 32 deletions frontend/src/components/collections/CollectionsRepoList.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div class="sm:w-[100%] sm:mt-[36px] pt-4 pb-8 px-2">
<!-- models -->
<div>
<div v-if="hasModels">
<h3 class="text-xl text-gray-700 flex items-center gap-[8px]">
<SvgIcon
name="models"
Expand All @@ -12,7 +12,6 @@
<span class="text-gray-400 text-md leading-[24px]">{{ models.length }}</span>
</h3>
<div
v-if="hasModels"
class="grid grid-cols-2 xl:grid-cols-1 gap-4 mb-4 mt-[16px]"
>
<div class="flex gap-2" v-for="model in models">
Expand All @@ -25,16 +24,10 @@
</div>
</div>
</div>
<div
v-else
class="flex flex-wrap gap-4 mb-4 mt-[16px]"
>
{{ $t('all.noData') }}
</div>
</div>

<!-- datasets -->
<div class="mt-[32px]">
<div class="mt-[32px]" v-if="hasDatasets">
<h3 class="text-xl text-gray-700 flex items-center gap-[8px]">
<SvgIcon
name="datasets"
Expand All @@ -45,7 +38,6 @@
<span class="text-gray-400 text-md leading-[24px]">{{ datasets.length }}</span>
</h3>
<div
v-if="hasDatasets"
class="grid grid-cols-2 xl:grid-cols-1 gap-4 mb-4 mt-[16px]"
>
<div class="flex gap-2" v-for="dataset in datasets">
Expand All @@ -58,16 +50,10 @@
</div>
</div>
</div>
<div
v-else
class="flex flex-wrap gap-4 mb-4 mt-[16px]"
>
{{ $t('all.noData') }}
</div>
</div>

<!-- code repo -->
<div class="mt-[32px]">
<div class="mt-[32px]" v-if="hasCodes">
<h3 class="text-xl text-gray-700 flex items-center gap-[8px]">
<SvgIcon
name="codes"
Expand All @@ -78,7 +64,6 @@
<span class="text-gray-400 text-md leading-[24px]">{{ codes.length }}</span>
</h3>
<div
v-if="hasCodes"
class="grid grid-cols-2 xl:grid-cols-1 gap-4 mb-4 mt-[16px]"
>
<div class="flex gap-2" v-for="code in codes">
Expand All @@ -91,16 +76,10 @@
</div>
</div>
</div>
<div
v-else
class="flex flex-wrap gap-4 mb-4 mt-[16px]"
>
{{ $t('all.noData') }}
</div>
</div>

<!-- spaces -->
<div class="mt-[32px]">
<div class="mt-[32px]" v-if="hasSpaces">
<h3 class="text-xl text-gray-700 flex items-center gap-[8px]">
<SvgIcon
name="spaces"
Expand All @@ -111,7 +90,6 @@
<span class="text-gray-400 text-md leading-[24px]">{{ spaces.length }}</span>
</h3>
<div
v-if="hasSpaces"
class="grid grid-cols-2 xl:grid-cols-1 gap-4 mb-4 mt-[16px]"
>
<div class="flex gap-2" v-for="space in spaces">
Expand All @@ -125,12 +103,6 @@
</div>
</div>
</div>
<div
v-else
class="flex flex-wrap gap-4 mb-4 mt-[16px]"
>
{{ $t('all.noData') }}
</div>
</div>
</div>
</template>
Expand Down

0 comments on commit 2fe84fb

Please sign in to comment.