Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor buttons in RepoClone.vue #899

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

youngbeom-shin
Copy link
Member

What this PR does:
Refactor buttons in RepoClone.vue to use CsgButton component for consistency and improved styling. Updated button properties and classes for better UI alignment and functionality.

Which issue(s) this PR fixes:

Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

Checklist:

  • I have added unit/e2e tests that prove your fix is effective or that this feature works.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have reviewed my own code and ensured that it follows the project's style guidelines.

Release note:


…istency and improved styling. Updated button properties and classes for better UI alignment and functionality.
@youngbeom-shin youngbeom-shin self-assigned this Jan 13, 2025
@youngbeom-shin
Copy link
Member Author

@zhendi, I still can’t see the sync button even though I already have the admin role. Could you help check what’s going on?

…s, improving robustness against undefined values.
Copy link
Collaborator

@zhendi zhendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngbeom-shin youngbeom-shin merged commit 28ffeb1 into main Jan 13, 2025
3 checks passed
@youngbeom-shin youngbeom-shin deleted the csghub__refactor-buttons-in-RepoClone.vue branch January 13, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants