-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sentinel-intel] Fix (MD5/SHA-1 support & Fix with file metadata) #3425
Conversation
b513b96
to
11a05bf
Compare
@romain-filigran Following our discussion, I've added a label to not merge until you finished, feel free to ping us when it's done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work as intended 👍
The issue is clear now and the fix is accurate, although the code could benefit from a little refacto to help with maintainability (see suggestions in comments) 🙌
Thanks!
stream/sentinel-intel/src/sentinel_intel_connector/api_handler.py
Outdated
Show resolved
Hide resolved
stream/sentinel-intel/src/sentinel_intel_connector/api_handler.py
Outdated
Show resolved
Hide resolved
stream/sentinel-intel/src/sentinel_intel_connector/connector.py
Outdated
Show resolved
Hide resolved
stream/sentinel-intel/src/sentinel_intel_connector/connector.py
Outdated
Show resolved
Hide resolved
stream/sentinel-intel/src/sentinel_intel_connector/connector.py
Outdated
Show resolved
Hide resolved
@Powlinett : Thank you for your review and comments. |
Proposed changes
Related issues
The deletion of indicators has also been corrected. This could solve these two problems:
Checklist