Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Align knowledge bar counters (#8115) #9304

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

delemaf
Copy link
Member

@delemaf delemaf commented Dec 11, 2024

Proposed changes

  • Fix distribution counters, also add counter for related entities
  • Refactor query with fragment for knowledge bar
  • NB: counters update is still not sync when entity is added (it's another bug 🐛 )

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@delemaf delemaf added the filigran team use to identify PR from the Filigran team label Dec 11, 2024
@delemaf delemaf self-assigned this Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.26%. Comparing base (790ad21) to head (d95bb0e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9304   +/-   ##
=======================================
  Coverage   65.26%   65.26%           
=======================================
  Files         630      630           
  Lines       60314    60314           
  Branches     6774     6777    +3     
=======================================
  Hits        39361    39361           
  Misses      20953    20953           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delemaf delemaf closed this Dec 18, 2024
@delemaf delemaf reopened this Dec 27, 2024
@delemaf delemaf changed the title [frontend] Incorrect display in Threat Actors menu category (#8115) [frontend] Align knowledge bar counters (#8115) Dec 27, 2024
@delemaf delemaf marked this pull request as ready for review January 2, 2025 15:39
@marieflorescontact marieflorescontact self-requested a review January 3, 2025 09:23
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested ok 👌
just a question: do we decide to move the counter from the Observables side to the Related entities side?

@Archidoit
Copy link
Member

If I am in a threat actor group and add 2 relationships with other threat actor groups, their are 2 relationships in the list, but the right counter indicates 3 :
image

@Archidoit
Copy link
Member

Relationships of tyep 'part of' are displayed when I am in the 'related to' section :
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
4 participants