Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] In Observable / Indicators composed with this observable view, fix the css(#9279) #9391

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

Gwendoline-FAVRE-FELIX
Copy link
Member

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX commented Dec 17, 2024

Proposed changes

  • Correct the position of the + button and the length of the truncate

Related issues

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX added the filigran team use to identify PR from the Filigran team label Dec 17, 2024
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX linked an issue Dec 17, 2024 that may be closed by this pull request
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX changed the title [frontend] In Observable / Indicators composed with this observable view the '+' button is too on the left and long description/name are troncated far before the end of the screen(#9279) [frontend] In Observable / Indicators composed with this observable view, fix the css(#9279) Dec 17, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.26%. Comparing base (1fba256) to head (88728ba).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9391   +/-   ##
=======================================
  Coverage   65.25%   65.26%           
=======================================
  Files         630      630           
  Lines       60311    60311           
  Branches     6776     6777    +1     
=======================================
+ Hits        39356    39361    +5     
+ Misses      20955    20950    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX marked this pull request as ready for review December 18, 2024 09:02
@Archidoit

This comment was marked as resolved.

@delemaf delemaf dismissed Archidoit’s stale review January 28, 2025 10:20

Changes have been made, I reviewed it after, it work well

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX merged commit 9276b5a into master Jan 28, 2025
9 checks passed
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX deleted the issue/9279 branch January 28, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad margin in 'Add indicators to observable' panel
3 participants