-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] In Observable / Indicators composed with this observable view, fix the css(#9279) #9391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gwendoline-FAVRE-FELIX
added
the
filigran team
use to identify PR from the Filigran team
label
Dec 17, 2024
Gwendoline-FAVRE-FELIX
changed the title
[frontend] In Observable / Indicators composed with this observable view the '+' button is too on the left and long description/name are troncated far before the end of the screen(#9279)
[frontend] In Observable / Indicators composed with this observable view, fix the css(#9279)
Dec 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9391 +/- ##
=======================================
Coverage 65.25% 65.26%
=======================================
Files 630 630
Lines 60311 60311
Branches 6776 6777 +1
=======================================
+ Hits 39356 39361 +5
+ Misses 20955 20950 -5 ☔ View full report in Codecov by Sentry. |
Archidoit
previously requested changes
Dec 18, 2024
.../private/components/observations/stix_cyber_observables/StixCyberObservableAddIndicators.jsx
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Gwendoline-FAVRE-FELIX
force-pushed
the
issue/9279
branch
from
January 6, 2025 08:42
5314cec
to
0e1dbd0
Compare
richard-julien
force-pushed
the
master
branch
5 times, most recently
from
January 13, 2025 09:27
b414944
to
c7f4cb7
Compare
Gwendoline-FAVRE-FELIX
force-pushed
the
issue/9279
branch
2 times, most recently
from
January 23, 2025 13:01
abf4363
to
c2fa987
Compare
delemaf
requested changes
Jan 27, 2025
...vate/components/common/stix_core_relationships/StixCoreRelationshipCreationFromEntityList.js
Outdated
Show resolved
Hide resolved
...vate/components/common/stix_core_relationships/StixCoreRelationshipCreationFromEntityList.js
Outdated
Show resolved
Hide resolved
Gwendoline-FAVRE-FELIX
force-pushed
the
issue/9279
branch
from
January 28, 2025 09:12
c2fa987
to
a6d42e8
Compare
delemaf
approved these changes
Jan 28, 2025
delemaf
dismissed
Archidoit’s stale review
January 28, 2025 10:20
Changes have been made, I reviewed it after, it work well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues