-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Widgets code refacto #9483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/6.5.0 #9483 +/- ##
==============================================
Coverage 65.38% 65.38%
==============================================
Files 626 626
Lines 60156 60166 +10
Branches 6771 6777 +6
==============================================
+ Hits 39334 39342 +8
- Misses 20822 20824 +2 ☔ View full report in Codecov by Sentry. |
5 tasks
Note: might need updates depending on which PR is merged first with #9194 |
Archidoit
force-pushed
the
issue/widget-refacto
branch
from
January 3, 2025 10:14
53eabd3
to
358c87e
Compare
ValentinBouzinFiligran
approved these changes
Jan 3, 2025
delemaf
approved these changes
Jan 3, 2025
Archidoit
force-pushed
the
issue/widget-refacto
branch
3 times, most recently
from
January 3, 2025 15:39
e32d991
to
3236e93
Compare
Archidoit
force-pushed
the
issue/widget-refacto
branch
from
January 6, 2025 13:37
3236e93
to
64806a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Refacto of the widgets code to make it more readable and reusable for the future fintel template widget logic