Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Widgets code refacto #9483

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Conversation

Archidoit
Copy link
Member

Proposed changes

Refacto of the widgets code to make it more readable and reusable for the future fintel template widget logic

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Jan 2, 2025
@Archidoit Archidoit self-assigned this Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.38%. Comparing base (c421910) to head (c1cf018).
Report is 3 commits behind head on release/6.5.0.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/6.5.0    #9483   +/-   ##
==============================================
  Coverage          65.38%   65.38%           
==============================================
  Files                626      626           
  Lines              60156    60166   +10     
  Branches            6771     6777    +6     
==============================================
+ Hits               39334    39342    +8     
- Misses             20822    20824    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard
Copy link
Member

Note: might need updates depending on which PR is merged first with #9194

@Archidoit Archidoit force-pushed the issue/widget-refacto branch from 53eabd3 to 358c87e Compare January 3, 2025 10:14
@Archidoit Archidoit force-pushed the issue/widget-refacto branch 3 times, most recently from e32d991 to 3236e93 Compare January 3, 2025 15:39
@Archidoit Archidoit changed the base branch from master to release/6.5.0 January 6, 2025 13:36
@Archidoit Archidoit force-pushed the issue/widget-refacto branch from 3236e93 to 64806a9 Compare January 6, 2025 13:37
@Archidoit Archidoit merged commit 31a8cd6 into release/6.5.0 Jan 7, 2025
5 checks passed
@Archidoit Archidoit deleted the issue/widget-refacto branch January 7, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants