[frontend] Update demographic stixCoreRelationships from entity overview #9637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
filigran team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9637 +/- ##
==========================================
+ Coverage 65.25% 65.50% +0.25%
==========================================
Files 630 630
Lines 60311 60475 +164
Branches 6776 7183 +407
==========================================
+ Hits 39356 39617 +261
+ Misses 20955 20858 -97 ☔ View full report in Codecov by Sentry. |
marieflorescontact
force-pushed
the
issue/8343
branch
from
65d188e to
48c5ccd
Compare
marieflorescontact
changed the title
lndrtrbn
reviewed
Jan 20, 2025
.../private/components/threats/threat_actors_individual/AddThreatActorIndividualDemographic.tsx
Outdated
Show resolved
Hide resolved
.../private/components/threats/threat_actors_individual/AddThreatActorIndividualDemographic.tsx
Outdated
Show resolved
Hide resolved
...ate/components/threats/threat_actors_individual/AddThreatActorIndividualDemographicLines.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
147
to
156
| const [currentTargets, setCurrentTargets] = useState<string[]>(initialTargets); | ||
|
|
||
| const updateDelete = (store: RecordSourceSelectorProxy, path: string, rootId: string, deleteId: string) => { | ||
| const node = store.get(rootId); | ||
| const records = node?.getLinkedRecord(path); | ||
| const edges = records?.getLinkedRecords('edges'); | ||
| if (!records || !edges) { return; } | ||
| const newEdges = edges.filter((n) => n.getLinkedRecord('node')?.getValue('toId') !== deleteId); | ||
| records.setLinkedRecords(newEdges, 'edges'); | ||
| }; |
There was a problem hiding this comment.
This code is a duplicate and seems pretty generic.
In fact it seems to be the same as deleteNodeFromEdge from store.js
There was a problem hiding this comment.
Remove it and use the function from store.js
There was a problem hiding this comment.
deleteNodeFromEdge uses "id" while updateDelete uses "toId"
For now, I have moved the updateDelete method to store.js since it is used three times.
Later, we can see if deleteNodeFromEdge and updateDelete can be combined into a single method.
...ate/components/threats/threat_actors_individual/AddThreatActorIndividualDemographicLines.tsx
Outdated
Show resolved
Hide resolved
...ate/components/threats/threat_actors_individual/AddThreatActorIndividualDemographicLines.tsx
Outdated
Show resolved
Hide resolved
marieflorescontact
force-pushed
the
issue/8343
branch
from
3d2daf6 to
e6b99e3
Compare
marieflorescontact
force-pushed
the
issue/8343
branch
from
e6b99e3 to
bffcf3f
Compare
…aThreatActorIndividual
…sThreatActorIndividual
|
PR status: all comments have been taken into account, ready for a second round of reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
AddPersonaThreatActorIndividualandAddIndividualsThreatActorIndividualand childs components :usePreloadedQueryinstead ofuseLazyLoadQuery,useFragmentinstead ofuseRefetchableFragment+ removeuseEffect()Related issues
Checklist
Further comments
othe