-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend/frontend] Threat actor group should not be part-of threat actor individual (#9576) #9649
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9649 +/- ##
==========================================
- Coverage 64.29% 64.26% -0.03%
==========================================
Files 655 655
Lines 62933 62909 -24
Branches 6964 6965 +1
==========================================
- Hits 40460 40428 -32
- Misses 22473 22481 +8 ☔ View full report in Codecov by Sentry. |
@SarahBocognano there is a bit more to do to solve the issue.
TAI -> part of -> TAG
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partial solution ; see my comment in the PR.
opencti-platform/opencti-graphql/src/migrations/migration-threat-actors-relationships.js
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-graphql/src/migrations/migration-threat-actors-relationships.js
Outdated
Show resolved
Hide resolved
d84eeae
to
a1b9872
Compare
a1b9872
to
b0ffbe9
Compare
58e6f36
to
9ee7a45
Compare
// eslint-disable-next-line no-plusplus | ||
for (let i = 0; i < invalidRelationships.length; i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// eslint-disable-next-line no-plusplus | |
for (let i = 0; i < invalidRelationships.length; i++) { | |
for (let i = 0; i < invalidRelationships.length; i+=1) { |
the fix is to use i+=1 instead of i++
Proposed changes
Related issues