Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] add configurable taxii feed ingestion pagination (#8697) #9659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Jan 21, 2025

Proposed changes

  • added a new INGESTION_MANAGER_TAXII_FEED_LIMIT_PER_REQUEST config parameter
  • if INGESTION_MANAGER_TAXII_FEED_LIMIT_PER_REQUEST is set and > 0, use it as a 'limit' parameter for taxii feed ingestion

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Taxii documentation: https://docs.oasis-open.org/cti/taxii/v2.1/taxii-v2.1.html

@JeremyCloarec JeremyCloarec linked an issue Jan 21, 2025 that may be closed by this pull request
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.25%. Comparing base (7ed76c1) to head (a467e62).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rm/opencti-graphql/src/manager/ingestionManager.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9659   +/-   ##
=======================================
  Coverage   65.24%   65.25%           
=======================================
  Files         630      630           
  Lines       60299    60302    +3     
  Branches     6773     6778    +5     
=======================================
+ Hits        39344    39350    +6     
+ Misses      20955    20952    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenCTI TAXII Feed - 413 Content Too Large
2 participants