Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upload artifact should work if only back or front has worked (#9687) #9681

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Jan 22, 2025

Proposed changes

  • check if folder to archive to JFrog exist before tar.gz, to be allowed to get either frontend/backend tests artefact even if the other steps fails.

Related issues

  • Example of fail api test build with artifact uploaded for frontend e2e tests

image

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 22, 2025
@aHenryJard aHenryJard changed the title Upload artifact should work if only back or front has worked [CI] Upload artifact should work if only back or front has worked Jan 23, 2025
@aHenryJard aHenryJard marked this pull request as ready for review January 23, 2025 07:26
@aHenryJard aHenryJard changed the title [CI] Upload artifact should work if only back or front has worked [CI] Upload artifact should work if only back or front has worked (#9687) Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.26%. Comparing base (25b9dfb) to head (c284a06).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9681      +/-   ##
==========================================
+ Coverage   65.25%   65.26%   +0.01%     
==========================================
  Files         630      630              
  Lines       60244    60244              
  Branches     6756     6763       +7     
==========================================
+ Hits        39312    39319       +7     
+ Misses      20932    20925       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard merged commit 0d2a3f8 into master Jan 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI/Drone] Make upload artefact step more resilient
2 participants