[frontend] Fix for user deletion on cache + prevent loop on error on Private Root (#9719) #9720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9720 +/- ##
==========================================
+ Coverage 65.24% 66.24% +1.00%
==========================================
Files 630 630
Lines 60273 60420 +147
Branches 6763 7340 +577
==========================================
+ Hits 39325 40028 +703
+ Misses 20948 20392 -556 ☔ View full report in Codecov by Sentry. |
delemaf
requested changes
Jan 27, 2025
| @@ -78,7 +83,7 @@ class ErrorBoundaryComponent extends React.Component { | |||
| const types = map((e) => e.extensions.code, [...baseErrors, ...retroErrors]); | |||
| // Specific error catching | |||
| if (includes('COMPLEX_SEARCH_ERROR', types)) { | |||
| return <DedicatedWarning title={'Complex search'} description={'Your search have too much terms to be executed. Please limit the number of words or the complexity'}/>; | |||
| return <DedicatedWarning title={'Complex search'} description={'Your search have too much terms to be executed. Please limit the number of words or the complexity'} />; | |||
There was a problem hiding this comment.
Should we also translate this ?
There was a problem hiding this comment.
I don't think I can inject formatter in ErrorBoundary
| @@ -141,7 +141,7 @@ const platformUsers = (context: AuthContext) => { | |||
| const reloadUsers = async () => { | |||
| const users = await listAllEntities(context, SYSTEM_USER, [ENTITY_TYPE_USER], { connectionFormat: false }); | |||
| const allUserIds = users.map((user) => user.internal_id); | |||
| return Bluebird.map(allUserIds, (userId: string) => resolveUserById(context, userId), { concurrency: ES_MAX_CONCURRENCY }); | |||
| return Bluebird.map(allUserIds, (userId: string) => resolveUserById(context, userId), { concurrency: ES_MAX_CONCURRENCY }).filter((u) => u != null); | |||
There was a problem hiding this comment.
why adding this filter ? can it happen ? since we just loaded the users from the database.
There was a problem hiding this comment.
Yes, there could be a weird race-case scenario where the cache is reset while a user is being deleted -> users contains an ID that exists no longer in elastic.
delemaf
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9719
1 - User deletion doesn't trigger cache reset, hence we are trying to get a user from the cache that is deleted
2 - The default error boundary component is not usable is RootPrivate fails because it requires Intl