Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] check multiple keys for meEdit mutation (#9739) #9741

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Jan 28, 2025

Proposed changes

  • check all keys of the input before action.
  • Add test

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@marieflorescontact marieflorescontact self-assigned this Jan 28, 2025
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 28, 2025
@aHenryJard aHenryJard changed the title [backend] check multiple keys for meEdit mutation [backend] check multiple keys for meEdit mutation (#9739) Jan 28, 2025
@marieflorescontact marieflorescontact marked this pull request as ready for review January 28, 2025 15:31
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 65.24%. Comparing base (1fba256) to head (8467948).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...pencti-platform/opencti-graphql/src/domain/user.js 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9741      +/-   ##
==========================================
- Coverage   65.25%   65.24%   -0.01%     
==========================================
  Files         630      630              
  Lines       60311    60330      +19     
  Branches     6776     6774       -2     
==========================================
+ Hits        39356    39364       +8     
- Misses      20955    20966      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg labo-flg changed the title [backend] check multiple keys for meEdit mutation (#9739) [backend] check multiple keys for meEdit mutation Jan 28, 2025
@aHenryJard aHenryJard changed the title [backend] check multiple keys for meEdit mutation [backend] check multiple keys for meEdit mutation (#9739) Jan 28, 2025
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me.

@SouadHadjiat SouadHadjiat merged commit b89f94c into master Jan 28, 2025
6 of 7 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/9739 branch January 28, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants