Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix reindex error on deleting old objects (#9270) #9742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Jan 28, 2025

Proposed changes

  • ignore i_valid_* fields that are not part of the mapping
  • add test with issue use case

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.25%. Comparing base (790ad21) to head (d460d48).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9742      +/-   ##
==========================================
- Coverage   65.26%   65.25%   -0.01%     
==========================================
  Files         630      630              
  Lines       60314    60317       +3     
  Branches     6774     6771       -3     
==========================================
+ Hits        39361    39362       +1     
- Misses      20953    20955       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reindexing fail from opencti_stix_core_relationships-000001 to opencti_deleted_objects
2 participants