Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Move background tasks execution to worker #9983

Open
wants to merge 49 commits into
base: release/6.6.0
Choose a base branch
from

Conversation

richard-julien
Copy link
Member

@richard-julien richard-julien commented Feb 16, 2025

[backend/frontend] Move background tasks execution to worker

  • On backend side remains only the task provisionning
  • After provisionning, only execution through worker

Require OpenCTI-Platform/client-python#842

Remaining:

  • Improve frontend view of background tasks to have a clear view between the provisionning task and the job execution
  • Improve frontend display of current tasks impacting an instance. POC done on container but ugly and need a full refresh.
  • Handle old background task after upgrade

@richard-julien richard-julien linked an issue Feb 16, 2025 that may be closed by this pull request
@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Feb 17, 2025
@richard-julien richard-julien added the multi-repository For contribution that requires PR in several repository label Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 20.23047% with 623 lines in your changes missing coverage. Please review.

Project coverage is 64.74%. Comparing base (9a9ce62) to head (16fa452).
Report is 40 commits behind head on release/6.6.0.

Files with missing lines Patch % Lines
...latform/opencti-graphql/src/manager/taskManager.js 5.68% 415 Missing ⚠️
...tform/opencti-graphql/src/domain/stixCoreObject.js 11.90% 74 Missing ⚠️
...latform/opencti-graphql/src/manager/ruleManager.ts 7.93% 58 Missing ⚠️
...pencti-platform/opencti-graphql/src/domain/stix.js 10.71% 25 Missing ⚠️
...latform/opencti-graphql/src/database/repository.js 0.00% 10 Missing ⚠️
...ncti-platform/opencti-graphql/src/database/smtp.js 9.09% 10 Missing ⚠️
...rm/opencti-graphql/src/resolvers/stixCoreObject.js 9.09% 10 Missing ⚠️
...-platform/opencti-graphql/src/database/rabbitmq.js 63.15% 7 Missing ⚠️
...tform/opencti-graphql/src/domain/backgroundTask.js 40.00% 3 Missing ⚠️
...src/utils/filtering/filtering-stix/stix-testers.ts 40.00% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.6.0    #9983      +/-   ##
=================================================
+ Coverage          64.08%   64.74%   +0.66%     
=================================================
  Files                655      655              
  Lines              63213    63933     +720     
  Branches            6982     7958     +976     
=================================================
+ Hits               40507    41394     +887     
+ Misses             22706    22539     -167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

| "rule_clear" # Clearing a rule (stop engine)
| "rules_rescan" # Rescan a rule (massive operation in UI)
| "enrichment" # Ask for enrichment (massive operation in UI)
| "clear_access_restriction" # Clear access members ((massive operation in UI)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see 'revert-draft' action here, is it somewhere else ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team multi-repository For contribution that requires PR in several repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change background tasks to execute operations through worker
2 participants