[CGCilk] Fix code generation of normal cleanup destination slot aroun… #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works for me. There is a typo in the test case, CHECK-NECT instead of CHECK-NEXT. |
…d unassociated taskframes.
neboat
force-pushed
the
dev/18.x-cilkscope-try-normal-cleanup
branch
from
90abedc to
de3ac80
Compare
|
Ah, good catch! That typo should be fixed in the latest version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d unassociated taskframes.
This PR fixes issue #287. In that issue, multiple normal cleanup destination slots were getting created for the unassociated taskframe. But the uses of those different slots were not connected to manage normal cleanups. It seems that clang's codegen does not easily support associating multiple such slots for normal cleanups.
This change makes unassociated taskframes use a preexisting normal cleanup slot allocated outside of the taskframe. Although this isn't ideal, in case the taskframe ends up outlined into a new function, it is semantically correct, because an unassociated taskframe executes serially with respect to their parent.