Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SemaExpr] Fix hyperobject-lookup lvalue conversion involving qualifi… #292

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[SemaExpr] Fix hyperobject-lookup lvalue conversion involving qualifi… #292

merged 1 commit into from
Dec 2, 2024

Conversation

neboat
Copy link
Collaborator

@neboat neboat commented Nov 30, 2024

…ers and xvalues.

@VoxSciurorum
Copy link
Contributor

My first reaction is this logic should be in stripHyperobject and not its callers. I have not tried this change.

@neboat neboat force-pushed the dev/18.x-hyper-lookup-lvalue-conversion branch from 0722f03 to c3cd843 Compare November 30, 2024 21:07
@neboat
Copy link
Collaborator Author

neboat commented Nov 30, 2024

OK, I moved the logic into stripHyperobject.

@neboat neboat merged commit 92bc96b into OpenCilk:dev/18.x Dec 2, 2024
4 checks passed
@neboat neboat deleted the dev/18.x-hyper-lookup-lvalue-conversion branch December 2, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neboat @VoxSciurorum