Fix Cilkscale with LLD #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that have been removed from the OpenCilk runtime system.
… requires instrumentation during or after Tapir lowering.
…le and cilkscale-instructions, to ensure instrumentation is inserted appropriately when using LLD with LTO.
We currently receive a warning on all Github Actions workflows that use `setup-python`, since they all use v4 of the action, which uses the deprecated Node.js 16. This PR upgrades the action in all places to v5, which uses Node.js 20 (see [setup-python release page](https://github.com/actions/setup-python/releases/tag/v5.0.0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
-fcilktool=cilkscalefunctionality when used with the LLD linker when using LTO. These changes ensure that Cilkscale's instrumentation during the post-link phase of LTO, around when Tapir instructions in the IR are lowered to a parallel runtime ABI.This PR also fixes some minor issues with Cilkscale's instrumentation, removes some now-unused linker flags, and updates the
python-setupGitHub action to resolve recent CI failures.