Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Bunch of October Updates to the developer docs #50

Merged
merged 15 commits into from
Nov 17, 2016
Merged

Conversation

caprenter
Copy link
Contributor

@caprenter caprenter commented Oct 24, 2016

A bunch of lots of minor updates to the existing developer docs. I think a review would allow to close most of the issues referenced. They may not be comprehensive, but I think it probably means the issue can be closed, brought under control and future improvements can be made as and when.

@caprenter caprenter changed the title Updates what is open data services code Bunch of October Updates to the developer docs Oct 24, 2016
@caprenter caprenter added this to the October Update milestone Oct 24, 2016
Copy link
Member

@Bjwebb Bjwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a couple of these commits are described incorrectly.

@@ -29,6 +29,13 @@ we want to collect - e.g. the different ways of identifying a commit
- tags, branches, HEAD~2, hash, short hash 0 for use with the git diff
etc.

### Push to 2 remotes at once
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be #38 not #37

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok - can you fix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

@@ -35,6 +35,9 @@ http://stackoverflow.com/questions/14290113/git-pushing-code-to-two-remotes#answ

`git remote set-url --add`

### git blame a diff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the previous commit 2854d48

@Bjwebb Bjwebb merged commit 18a9d01 into master Nov 17, 2016
@Bjwebb Bjwebb deleted the october-update branch November 17, 2016 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants