-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round search #26
Open
D0ugins
wants to merge
173
commits into
OpenDebate:v3
Choose a base branch
from
D0ugins:round-search
base: v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Round search #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the roughly 200,000 files, there is a decent chance of a collision between two file ids. Switching to 64 bit lowers the chance to around 1/1000
Currently designed for development only.
Client is generated using openapi-generator-cli, can be run with yarn run generate Uses the request based typescript-node generator because ones like typescript-axios are missing a lot of features
Online version of the schema is outdated
tryBuild would retry the same path in different orders
Keep track of states with known return values across runs Could implement bidirectional search if needed
Also now stores card length and SubBucket id in seperate keys Allows using mget instead of repeated hgetall Significant performance at the cost of 80 bytes per card, around 300MB with full dataset
Field to keep track of the updated_at time the caselist has for the currently stored version of a round
Periodically checks the /recent route of caselists for new updates and downloads them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates pgsync and implements searching rounds by cites and round report.
Cites are searched through pgsync, round reports are through postgres using
LIKE
queriesFiltering could be added to improve search
More advanced search could be implemented in the future, such as parsing round reports into separate speeches or separating cites into individual cites.