DRAFT - Implementation DEYE SUN-12K-SG04LP3-EU #2614

Rayleigh3105 · 2024-04-09T06:48:34Z

No description provided.

Sn0w3y · 2024-04-09T17:28:22Z

@Rayleigh3105 this is 100% not finished, maybe consider marking this PR as draft as I and the others know based on the "Copy-Paste" it is not finished yet - will add some comments beforehand :)

See for e.g.:

https://openems.github.io/openems.io/openems/latest/contribute/coding-guidelines.html

Your complete Checkstyle is missing, there are no tests, and so on and so forth

Sn0w3y

To maintain transparency, I believe it would be more efficient for @sfeilmeier if you could address the issues in this pull request before resubmitting it. Like you, I am diligently working on my pull requests and acknowledge that I am not without fault. Based on my observations, @sfeilmeier is undoubtedly busy and appreciates contributions. However, he also faces the challenge of reviewing a significant amount of code that may be redundant, unnecessary, or incorrect in some pull requests, including some of my own.

Sn0w3y · 2024-04-09T18:27:33Z

io.openems.edge.batteryinverter.deye/src/io/openems/edge/deye/common/Config.java

+	@AttributeDefinition(name = "Modbus-Unit-ID", description = "Unit ID of Modbus bridge.")
+	int unit_id() default 0;
+
+	@AttributeDefinition(name = "Power limit on PowerDecreaseCausedByOvertemperature error; '0' to disable power limit logic", description = "")


What does this Config Point do?

Maybe consider changing it to something like:

@AttributeDefinition(name = "ThermalPowerLimitControl", description = "Defines the power limit adjustment in response to overtemperature events. Set to '0' to disable.")

Done - Removed.

Sn0w3y · 2024-04-09T18:32:30Z

io.openems.edge.batteryinverter.deye/src/io/openems/edge/deye/common/Config.java

+	@AttributeDefinition(name = "Surplus Feed-In: PV-Limit on PowerDecreaseCausedByOvertemperature", description = "")
+	int surplusFeedInPvLimitOnPowerDecreaseCausedByOvertemperature() default 5_000;
+
+	String webconsole_configurationFactory_nameHint() default "Deye [{id}]";


Deye what? Maybe also consider to refactor the Config if all of the Settings are needed for this "quite Simple" ESS ? As this all is copied from Fenecon Commercial 40 personally I do not think it is needed to set all these things up here

Sn0w3y · 2024-04-09T18:42:28Z

io.openems.edge.batteryinverter.deye/src/io/openems/edge/deye/common/DeyeSunHybridImpl.java

+	private static final int MIN_REACTIVE_POWER = -10000;
+
+	private static final int MAX_REACTIVE_POWER = 10000;
+


why are these for e.g. Hard Coded ? Aren't there more then one Combinations Possible ?

This is just copied from commerical 40. Dont know if I need these.

Sn0w3y · 2024-04-09T18:43:35Z

io.openems.edge.batteryinverter.deye/src/io/openems/edge/deye/common/DeyeSunHybridImpl.java

+				ModbusComponent.ChannelId.values(), //
+				SymmetricEss.ChannelId.values(), //
+				ManagedSymmetricEss.ChannelId.values(), //
+				HybridEss.ChannelId.values(), //


Are all of these really needed ? Seems like most of them are Commercial specific...

Sn0w3y · 2024-04-09T18:46:56Z

io.openems.edge.batteryinverter.deye/src/io/openems/edge/deye/common/DeyeSunHybridImpl.java

+
+	private LocalDateTime lastDefineWorkState = null;
+
+	private void defineWorkState() {


Is there a "Work State" on Deye ?

Deye does have a run state.

Sn0w3y · 2024-04-09T18:47:45Z

io.openems.edge.batteryinverter.deye/src/io/openems/edge/deye/common/DeyeSunHybridImpl.java

+		return new Constraint[] { //
+				this.createPowerConstraint("Commercial40 Min Reactive Power", Phase.ALL, Pwr.REACTIVE,
+						Relationship.GREATER_OR_EQUALS, MIN_REACTIVE_POWER), //
+				this.createPowerConstraint("Commercial40 Max Reactive Power", Phase.ALL, Pwr.REACTIVE,


Commercial 40 ?

Sn0w3y · 2024-04-09T18:48:52Z

io.openems.edge.batteryinverter.deye/src/io/openems/edge/deye/common/SurplusFeedInHandler.java

+public class SurplusFeedInHandler {
+
+	private static final int GOING_DEACTIVATED_MINUTES = 15;
+	private static final float PV_LIMIT_FACTOR = 0.9f;


All of these values are Commercial 40 related i guess..

Sn0w3y · 2024-04-09T18:49:05Z

io.openems.edge.batteryinverter.deye/src/io/openems/edge/deye/common/SurplusFeedInHandler.java

+		var areSurplusConditionsMet = this.areSurplusConditionsMet(this.parent, chargers, config);
+
+		if (chargers.isEmpty()) {
+			// Is no Charger set (i.e. is this not a Commercial 40-40 "DC")


Again commercial 40 related ?

Sn0w3y · 2024-04-10T07:39:57Z

@Rayleigh3105 you completely reverted my changes again..

I am sorry but as @sfeilmeier also told me please consider looking into the getting started and also learn some things about github before creating a PR please.. also use the getting started please !

Sn0w3y · 2024-04-10T19:14:32Z

@Rayleigh3105 reformatted it again, removed unused Classes again, please do not revert as it is not needed :)

Rayleigh3105 · 2024-04-11T08:19:31Z

@Sn0w3y Ahh sorry never wanted to create a PR this early. I just played around in gitHub. I´m trying to sort out the code in the next days 😆

github-actions · 2024-04-12T05:09:01Z

github-actions · 2024-04-12T11:02:22Z

Rayleigh3105 · 2024-04-12T12:56:06Z

...enems.edge.batteryinverter.deye/src/io/openems/edge/deye/productionmeter/PvInverterDeye.java

+		final Consumer<Value<Integer>> calculate = ignore -> {
+			final Integer generatorPower = meter.getActivePowerGen().getNextValue().get();
+			Integer generatorPowerToSet = 0;
+
+			if (generatorPower > 32768) {
+				generatorPowerToSet = generatorPower - 65536;
+			} else {
+				generatorPowerToSet = generatorPower;
+			}
+
+			meter._setActivePower(TypeUtils.sum(//
+					meter.getActivePowerS1Channel().getNextValue().get(), //
+					meter.getActivePowerS2Channel().getNextValue().get(), //
+					meter.getActivePowerS3Channel().getNextValue().get(), //
+					meter.getActivePowerS4Channel().getNextValue().get(), generatorPowerToSet)); //
+		};
+		meter.getActivePowerS1Channel().onSetNextValue(calculate);
+		meter.getActivePowerS2Channel().onSetNextValue(calculate);
+		meter.getActivePowerS3Channel().onSetNextValue(calculate);
+		meter.getActivePowerS4Channel().onSetNextValue(calculate);
+		meter.getActivePowerGen().onSetNextValue(calculate);


@Sn0w3y Is this the right way to implement the Gen Port on a inverter?

What do you mean with "Gen Port" ?

Deye does have a port to plug in a Generator source. Like a Diesel generator. So the values what it generates are now written to active power.

I think the right behavior for this case would be to implement a new meter for the generator Port. It is a external source which can produce energy, but also take energy. Maybe it would be nice to view the values of the generator port in the UI

https://www.akkudoktor.net/forum/deye-wechselrichter/deye-12k-frage-zum-generator-port-wechsel-der-nutzart/

Rayleigh3105 · 2024-04-12T13:03:13Z

To maintain transparency, I believe it would be more efficient for @sfeilmeier if you could address the issues in this pull request before resubmitting it. Like you, I am diligently working on my pull requests and acknowledge that I am not without fault. Based on my observations, @sfeilmeier is undoubtedly busy and appreciates contributions. However, he also faces the challenge of reviewing a significant amount of code that may be redundant, unnecessary, or incorrect in some pull requests, including some of my own.

Yeah never meant to open the PR in this stage, did forgot to make it a draft. Thanks for your participation.

Sn0w3y · 2024-04-15T07:08:07Z

@Rayleigh3105 could you please check if the Code works for your Deye ?

github-actions · 2024-04-15T07:14:14Z

Rayleigh3105 · 2024-04-15T08:19:03Z

@Sn0w3y Deplyoed it to the raspi. Code still working 👍 Now running on commit 3082fed

Rayleigh3105 · 2024-04-16T06:48:08Z

@Sn0w3y Deplyoed it to the raspi. Code still working 👍 Now running on commit 3082fed

Hi @Sn0w3y, unfurtunally it did not work as expected. Thee ESS broke with this change of the code. I reseted the branch and tested every commit. Now its working again.

…ht way

- 48ce729

sfeilmeier · 2025-03-04T16:35:40Z

I took some time to review as the Deye inverter is popular and it would be nice to have it in standard. https://community.openems.io/t/implementation-deye-inverter-approach/2541/16. But honestly at the moment the code is not very good. Most part is just copied from FENECON Commercial 40, with lots of unused channels etc.. Also most JUnit tests are missing at the moment.

Please somebody else take over from here... :-)

codecov · 2025-03-04T16:45:10Z

Codecov Report

Attention: Patch coverage is 3.47826% with 444 lines in your changes missing coverage. Please review.

❌ Your patch check has failed because the patch coverage (3.48%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #2614      +/-   ##
=============================================
+ Coverage      58.42%   60.46%   +2.04%     
  Complexity       139      139              
=============================================
  Files           2477     2213     -264     
  Lines         105240    98557    -6683     
  Branches        7770     6678    -1092     
=============================================
- Hits           61480    59580    -1900     
+ Misses         41518    36823    -4695     
+ Partials        2242     2154      -88

moritzvogt31 added 2 commits April 8, 2024 13:08

Start implement DEYE battery inverter

c2e240a

Start implement DEYE battery inverter

10610e8

Sn0w3y suggested changes Apr 9, 2024

View reviewed changes

Rayleigh3105 force-pushed the production_meter branch from 25220d3 to a308f1b Compare April 10, 2024 06:41

Rayleigh3105 changed the title ~~Production meter~~ DRAFT - Production meter Apr 11, 2024

Rayleigh3105 changed the title ~~DRAFT - Production meter~~ DRAFT - Implementation DEYE SUN-12K-SG04LP3-EU Apr 11, 2024

Rayleigh3105 marked this pull request as draft April 11, 2024 08:29

Rayleigh3105 commented Apr 12, 2024

View reviewed changes

Rayleigh3105 closed this Apr 12, 2024

Rayleigh3105 reopened this Apr 15, 2024

Rayleigh3105 force-pushed the production_meter branch 2 times, most recently from da67180 to e05dded Compare April 16, 2024 06:46

moritzvogt31 and others added 7 commits April 16, 2024 08:55

Start implement DEYE battery inverter

1f8915b

Start implement DEYE battery inverter

a682d24

Deye implementation

f7c4086

Update implementation for PV Inverter - DEYE

08f75af

Update implementation for PV Inverter - DEYE Calculate energy the rig…

9407312

…ht way

Update implementation of DEYE Grid meter

087902b

Implementing DEYE inverter

54e65b6

Rayleigh3105 added 13 commits April 16, 2024 08:56

Implement ESS for DEYE Inverter

87aa687

Ignore negavtive values on generator Port

9a029e2

Use right variable

1e5adc5

Re Implement Generator Port

852a163

Formatting and Refactoring - 00eb6e1

69a6e9f

Remove unused imports - f728fa9

e9452d4

Delete io.openems.edge.evcs.spelsberg/generated/buildfiles

16e1dd6

- 48ce729

Delete io.openems.edge.io.gpio/generated/buildfiles - b10da12

0ab5a1b

Removed wrong Component Names - a041a91

232bbb4

Implement a Grid_Meter Test - 73092e3

a72c692

Removed not needed Channels - commit 09fdc3e

654fdca

Remove not necessary code

94cd89b

Remove not necessary code

240240f

Rayleigh3105 force-pushed the production_meter branch from edc660d to 240240f Compare April 16, 2024 06:56

Rayleigh3105 and others added 5 commits April 16, 2024 16:08

Rename package for ess

1556956

Merge branch 'OpenEMS:develop' into production_meter

15c3bae

Merge remote-tracking branch 'origin/develop' into production_meter

ac6b6f1

prepare-commit

7e6a83e

Organize imports + formatting

5424d3b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DRAFT - Implementation DEYE SUN-12K-SG04LP3-EU #2614

DRAFT - Implementation DEYE SUN-12K-SG04LP3-EU #2614

Rayleigh3105 commented Apr 9, 2024

Sn0w3y commented Apr 9, 2024 •

edited

Loading

Sn0w3y left a comment

Sn0w3y Apr 9, 2024

Rayleigh3105 Apr 15, 2024 •

edited

Loading

Sn0w3y Apr 9, 2024

Rayleigh3105 Apr 15, 2024

Sn0w3y Apr 9, 2024

Rayleigh3105 Apr 15, 2024

Sn0w3y Apr 9, 2024

Sn0w3y Apr 9, 2024

Rayleigh3105 Apr 15, 2024

Sn0w3y Apr 9, 2024

Rayleigh3105 Apr 15, 2024

Sn0w3y Apr 9, 2024

Rayleigh3105 Apr 15, 2024

Sn0w3y Apr 9, 2024

Rayleigh3105 Apr 15, 2024

Sn0w3y commented Apr 10, 2024

Sn0w3y commented Apr 10, 2024

Rayleigh3105 commented Apr 11, 2024

github-actions bot commented Apr 12, 2024

github-actions bot commented Apr 12, 2024

Rayleigh3105 Apr 12, 2024

Sn0w3y Apr 12, 2024

Rayleigh3105 Apr 15, 2024

Rayleigh3105 Apr 15, 2024 •

edited

Loading

Rayleigh3105 commented Apr 12, 2024 •

edited

Loading

Sn0w3y commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

Rayleigh3105 commented Apr 15, 2024

Rayleigh3105 commented Apr 16, 2024 •

edited

Loading

sfeilmeier commented Mar 4, 2025

codecov bot commented Mar 4, 2025

		private static final int MIN_REACTIVE_POWER = -10000;

		private static final int MAX_REACTIVE_POWER = 10000;


		private LocalDateTime lastDefineWorkState = null;

		private void defineWorkState() {

DRAFT - Implementation DEYE SUN-12K-SG04LP3-EU #2614

Are you sure you want to change the base?

DRAFT - Implementation DEYE SUN-12K-SG04LP3-EU #2614

Conversation

Rayleigh3105 commented Apr 9, 2024

Sn0w3y commented Apr 9, 2024 • edited Loading

Sn0w3y left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rayleigh3105 Apr 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sn0w3y commented Apr 10, 2024

Sn0w3y commented Apr 10, 2024

Rayleigh3105 commented Apr 11, 2024

github-actions bot commented Apr 12, 2024

github-actions bot commented Apr 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rayleigh3105 Apr 15, 2024 • edited Loading

Choose a reason for hiding this comment

Rayleigh3105 commented Apr 12, 2024 • edited Loading

Sn0w3y commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

Rayleigh3105 commented Apr 15, 2024

Rayleigh3105 commented Apr 16, 2024 • edited Loading

sfeilmeier commented Mar 4, 2025

codecov bot commented Mar 4, 2025

Codecov Report

Sn0w3y commented Apr 9, 2024 •

edited

Loading

Rayleigh3105 Apr 15, 2024 •

edited

Loading

Rayleigh3105 Apr 15, 2024 •

edited

Loading

Rayleigh3105 commented Apr 12, 2024 •

edited

Loading

Rayleigh3105 commented Apr 16, 2024 •

edited

Loading