Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow replacement of supervision control block reference, closes #79. #82

Closed

Conversation

danyill
Copy link
Collaborator

@danyill danyill commented Jan 27, 2024

Closes #79.

I also don't know if any of this is a good idea.

I've left a few formatting updates from npm run format in here.

@danyill danyill force-pushed the issue-79-allow-ref-replace branch from 4b57592 to 8ffec66 Compare January 28, 2024 06:18
@danyill danyill force-pushed the issue-79-allow-ref-replace branch from 8ffec66 to 8065496 Compare January 28, 2024 06:27
@JakobVogelsang
Copy link
Contributor

Dear @danyill. I just had the time to look at your RP. Thank you for pushing the scl-lib.

There are two option that I see.

  1. Replace be inherently set when the supervision.iedOrLn is LN. Then we just move the existing supervision to a new logical node. This required the iedOrLn be empty (no Val element with inner text)
  2. Remove the supervision before creating a new one. For this could just export the removeSubscriptionSupervision function. Then still all check would apply and you would have some fail savety.

@JakobVogelsang
Copy link
Contributor

There are updates on #79. I would like to close this PR and finalize the refinement on #79 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tLN: Instantiate supervision with valid control block reference but no related subscriptions
2 participants