Fix checkstyle errors

Try to catch errors earlier
OpenGamma · Oct 30, 2018 · c31b328 · c31b328
1 parent 0ef60e4
commit c31b328
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/...rc/main/java/com/opengamma/strata/market/param/CurrencyParameterSensitivitiesBuilder.java b/...rc/main/java/com/opengamma/strata/market/param/CurrencyParameterSensitivitiesBuilder.java
@@ -18,7 +18,7 @@
 import com.opengamma.strata.data.MarketDataName;
 
 /**
- * Builder for {@code CurrencyParameterSensitivities}
+ * Builder for {@code CurrencyParameterSensitivities}.
  */
 public final class CurrencyParameterSensitivitiesBuilder {
 

diff --git a/...rket/src/main/java/com/opengamma/strata/market/sensitivity/CurveSensitivitiesBuilder.java b/...rket/src/main/java/com/opengamma/strata/market/sensitivity/CurveSensitivitiesBuilder.java
@@ -18,7 +18,7 @@
 import com.opengamma.strata.product.PortfolioItemInfo;
 
 /**
- * Builder for {@code CurveSensitivities}
+ * Builder for {@code CurveSensitivities}.
  */
 public final class CurveSensitivitiesBuilder {
 

diff --git a/modules/pom.xml b/modules/pom.xml
@@ -125,6 +125,9 @@
             <goals>
               <goal>checkstyle</goal>
             </goals>
+            <configuration>
+              <failsOnError>true</failsOnError>
+            </configuration>
           </execution>
         </executions>
       </plugin>
@@ -631,7 +634,7 @@
                     <dependency>
                       <groupId>${project.groupId}</groupId>
                       <artifactId>${project.artifactId}</artifactId>
-                      <version>1.3.0</version>
+                      <version>2.0.0</version>
                     </dependency>
                   </oldVersion>
                 </configuration>

diff --git a/modules/product/src/main/java/com/opengamma/strata/product/SimpleLegalEntity.java b/modules/product/src/main/java/com/opengamma/strata/product/SimpleLegalEntity.java
@@ -34,17 +34,17 @@ public final class SimpleLegalEntity implements LegalEntity, Serializable, Immut
    * The legal entity identifier.
    */
   @PropertyDefinition(validate = "notNull", overrideGet = true)
-  public final LegalEntityId legalEntityId;
+  private final LegalEntityId legalEntityId;
   /**
    * The legal entity name.
    */
   @PropertyDefinition(validate = "notNull", overrideGet = true)
-  public final String name;
+  private final String name;
   /**
    * The country that the legal entity is based in.
    */
   @PropertyDefinition(validate = "notNull", overrideGet = true)
-  public final Country country;
+  private final Country country;
 
   //------------------------- AUTOGENERATED START -------------------------
   /**