Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pet #1345

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Pet #1345

wants to merge 10 commits into from

Conversation

c4c1n6kr3m1
Copy link
Contributor

$pet{ID} always undef
it's reverse on iRO
that's why Wx pet doesn't work
need test for other servers

@alisonrag
Copy link
Contributor

will test soon

no need to record pet if is not yours
clear %pet on login
@alisonrag
Copy link
Contributor

@c4c1n6kr3m1
can we merge this?

send us some screenshots

@@ -2020,6 +2020,7 @@ sub item_skill {
sub map_changed {
my ($self, $args) = @_;
$net->setState(4);
%pet = ();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, i might saying nonsense...

but why this needs to stay here? i mean, is already declared at Globals.pm isn't?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh now i understand, is to clear old values right? sorry for misunderstanding

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this should be in functions.pl, not here

Copy link
Contributor Author

@c4c1n6kr3m1 c4c1n6kr3m1 Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lututui , the pet ID changed every map server , iRO

i put the code on functions.pl at november last year, work at that time
but not working with our bot date august with xkore 1 /3, so i need to put it on map_changed,looks like something is changed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But when map changes the method on functions.pl is always called... Or am I wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants