Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compile new executable #3611

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

@alisonrag alisonrag mentioned this pull request Aug 23, 2022
6 tasks
@alisonrag alisonrag changed the title Feature/compile new executables feat: compile new executable Aug 24, 2022
@ya4ept
Copy link
Contributor

ya4ept commented Aug 27, 2022

  • we have an error:
Use of uninitialized value $Interface::Tk::buildType in numeric eq (==) at src/Interface/Tk.pm line 65.
Use of uninitialized value $Interface::Tk::buildType in numeric eq (==) at src/Interface/Tk.pm line 479
  • when you run openkore.exe, we have two applications open (the console does not close)

@alisonrag
Copy link
Contributor Author

alisonrag commented Aug 27, 2022

  • we have an error:
Use of uninitialized value $Interface::Tk::buildType in numeric eq (==) at src/Interface/Tk.pm line 65.
Use of uninitialized value $Interface::Tk::buildType in numeric eq (==) at src/Interface/Tk.pm line 479

fixed at:
https://github.com/OpenKore/openkore/pull/3605/files#diff-4f2ba57fede7a665ce12a64539efe1a54acb94b2d46d3a0d66514c6602adcf52L48

@ya4ept
Copy link
Contributor

ya4ept commented Aug 28, 2022

fixed at:

OK

  • start-poseidon.exe does not work because it is looking for start.exe, wxstart.exe or korebin.exe

@alisonrag
Copy link
Contributor Author

alisonrag commented Aug 28, 2022

fixed at:

OK

  • start-poseidon.exe does not work because it is looking for start.exe, wxstart.exe or korebin.exe

fixed at:
5759961

@ya4ept
Copy link
Contributor

ya4ept commented Aug 28, 2022

@ya4ept
Copy link
Contributor

ya4ept commented Aug 28, 2022

10Mb for start-poseidon.exe is too much )))
We can use #3497 for that. Then the file size will be 100Kb

For testing: output.zip

We can add to the documentation a way to get "start-poseidon.exe", and remove it from the distribution:

  1. Run script-launcher\generator.exe
  2. Enter "src/Poseidon/poseidon.pl"
  3. Press Enter again

@ya4ept
Copy link
Contributor

ya4ept commented Sep 3, 2022

@alisonrag why do we need src/Poseidon/start.pl?
we can use:

1) Run script-launcher\generator.exe
2) Enter "src/Poseidon/poseidon.pl"
2) Press Enter again

src/Poseidon/start.pl Outdated Show resolved Hide resolved
@alisonrag
Copy link
Contributor Author

@alisonrag why do we need src/Poseidon/start.pl? we can use:

1) Run script-launcher\generator.exe
2) Enter "src/Poseidon/poseidon.pl"
2) Press Enter again

is just in case someone want to make a standalone by himself.
executable is not included just the code to generate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants