Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELV3-785: Dashboard reports definition #10

Merged
merged 2 commits into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,14 @@
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.data.repository.CrudRepository;
import org.springframework.test.annotation.DirtiesContext;
import org.springframework.test.context.ActiveProfiles;
import org.springframework.test.context.junit4.SpringRunner;
import org.springframework.transaction.annotation.Transactional;

@Transactional
@SpringBootTest
@DirtiesContext
@ActiveProfiles("test")
@RunWith(SpringRunner.class)
public abstract class BaseCrudRepositoryIntegrationTest<T extends BaseEntity> {

Expand All @@ -41,12 +43,17 @@ public abstract class BaseCrudRepositoryIntegrationTest<T extends BaseEntity> {
*/
abstract T generateInstance();

private AtomicInteger instanceNumber = new AtomicInteger(0);
private final AtomicInteger instanceNumber = new AtomicInteger(0);
private final AtomicInteger categoryNumber = new AtomicInteger(0);

int getNextInstanceNumber() {
return this.instanceNumber.incrementAndGet();
}

int getNextCategoryNumber() {
return this.categoryNumber.incrementAndGet();
}

protected void assertInstance(T instance) {
Assert.assertNotNull(instance.getId());
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,222 @@
/*
* This program is part of the OpenLMIS logistics management information system platform software.
* Copyright © 2017 VillageReach
*
* This program is free software: you can redistribute it and/or modify it under the terms
* of the GNU Affero General Public License as published by the Free Software Foundation, either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY;
* without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
* See the GNU Affero General Public License for more details. You should have received a copy of
* the GNU Affero General Public License along with this program. If not, see
* http://www.gnu.org/licenses.  For additional information contact [email protected].
*/

package org.openlmis.report.repository;

import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.notNullValue;
import static org.junit.Assert.assertThat;

import java.util.List;
import java.util.Optional;
import java.util.UUID;

import org.junit.Test;
import org.junit.jupiter.api.BeforeEach;
import org.openlmis.report.domain.DashboardReport;
import org.openlmis.report.domain.ReportCategory;
import org.openlmis.report.utils.DashboardReportDataBuilder;
import org.openlmis.report.utils.ReportCategoryDataBuilder;
import org.openlmis.report.utils.ReportType;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.data.domain.Page;
import org.springframework.data.domain.PageRequest;
import org.springframework.data.domain.Pageable;

public class DashboardReportRepositoryIntegrationTest extends
BaseCrudRepositoryIntegrationTest<DashboardReport> {
private static final String NAME = "DashboardReportIntegrationTest";
private static final String UPDATED_NAME = "UPDATED_DashboardReportIntegrationTest";
private static final String URL = "http://example.com";
private static final String CATEGORY_NAME = "Default Category";

@Autowired
private DashboardReportRepository dashboardReportRepository;

@Autowired
private ReportCategoryRepository reportCategoryRepository;

@Override
DashboardReportRepository getRepository() {
return this.dashboardReportRepository;
}

@Override
protected DashboardReport generateInstance() {
ReportCategory category = reportCategoryRepository
.save(new ReportCategoryDataBuilder().buildAsNew());

return new DashboardReportDataBuilder()
.withName(NAME)
.withUrl(URL)
.withType(ReportType.POWERBI)
.withEnabled(true)
.withShowOnHomePage(false)
.withCategory(category)
.buildAsNew();
}

@BeforeEach
public void setUp() {
dashboardReportRepository.deleteAll();
reportCategoryRepository.deleteAll();
}

@Test
public void shouldFindDashboardReportByName() {
DashboardReport dashboardReport = dashboardReportRepository.save(generateInstance());
boolean exists = dashboardReportRepository.existsByName(dashboardReport.getName());

assertThat(exists, is(true));
}

@Test
public void shouldFindAllDashboardReports() {
Pageable pageable = PageRequest.of(0, 3);
ReportCategory defaultCategory = reportCategoryRepository.save(
new ReportCategoryDataBuilder().buildAsNew()
);

DashboardReport dashboardReport1 = new DashboardReportDataBuilder()
.withCategory(defaultCategory)
.withShowOnHomePage(true)
.build();
DashboardReport dashboardReport2 = new DashboardReportDataBuilder()
.withCategory(defaultCategory)
.build();
DashboardReport dashboardReport3 = new DashboardReportDataBuilder()
.withCategory(defaultCategory)
.build();

dashboardReportRepository.save(dashboardReport1);
dashboardReportRepository.save(dashboardReport2);
dashboardReportRepository.save(dashboardReport3);

Page<DashboardReport> page = dashboardReportRepository.findAll(pageable);
List<DashboardReport> found = page.getContent();

assertThat(found.size(), is(3));
assertThat(page.getTotalElements(), is(3L));
}

@Test
public void shouldDeleteDashboardReportAndLeaveCategory() {
ReportCategory defaultCategory = reportCategoryRepository.save(
new ReportCategoryDataBuilder().buildAsNew()
);

DashboardReport dashboardReport = new DashboardReportDataBuilder()
.withCategory(defaultCategory)
.build();

dashboardReportRepository.save(dashboardReport);
dashboardReportRepository.delete(dashboardReport);

boolean dashboardReportExists = dashboardReportRepository.existsById(dashboardReport.getId());
assertThat(dashboardReportExists, is(false));

boolean reportCategoryExists = reportCategoryRepository.existsById(defaultCategory.getId());
assertThat(reportCategoryExists, is(true));
}

@Test
public void shouldUpdateDashboardReport() {
ReportCategory reportCategory = reportCategoryRepository.save(
new ReportCategoryDataBuilder().buildAsNew()
);
DashboardReport dashboardReport = dashboardReportRepository.save(
new DashboardReportDataBuilder().withName(NAME).withCategory(reportCategory).build()
);

assertThat(dashboardReport.getName(), is(NAME));
assertThat(dashboardReport.getType(), is(ReportType.SUPERSET));
assertThat(dashboardReport.getCategory().getId(), is(reportCategory.getId()));

ReportCategory newReportCategory = reportCategoryRepository.save(
new ReportCategoryDataBuilder().withName(CATEGORY_NAME).build()
);

dashboardReport.setName(UPDATED_NAME);
dashboardReport.setType(ReportType.POWERBI);
dashboardReport.setCategory(newReportCategory);

dashboardReportRepository.save(dashboardReport);

DashboardReport updatedReport = dashboardReportRepository.findById(
dashboardReport.getId()).orElse(null);

assertThat(updatedReport, is(notNullValue()));
assertThat(updatedReport.getName(), is(UPDATED_NAME));
assertThat(updatedReport.getType(), is(ReportType.POWERBI));
assertThat(updatedReport.getCategory().getId(), is(newReportCategory.getId()));
}

@Test
public void shouldSaveDashboardReport() {
ReportCategory reportCategory = reportCategoryRepository.save(
new ReportCategoryDataBuilder().buildAsNew()
);
DashboardReport dashboardReport = new DashboardReportDataBuilder().withName(NAME)
.withCategory(reportCategory).build();
DashboardReport savedReport = dashboardReportRepository.save(dashboardReport);

assertThat(savedReport.getId(), is(notNullValue()));
assertThat(savedReport.getName(), is(NAME));
}

@Test
public void shouldNotFindNonExistentDashboardReportById() {
Optional<DashboardReport> foundReport = dashboardReportRepository.findById(UUID.randomUUID());
assertThat(foundReport.isPresent(), is(false));
}

@Test
public void shouldNotFindNonExistentDashboardReportByName() {
boolean exists = dashboardReportRepository
.existsByName("Non-Existent name");

assertThat(exists, is(false));
}

@Test
public void shouldFindOnlyEnabledDashboardReports() {
Pageable pageable = PageRequest.of(0, 10);
ReportCategory defaultCategory = reportCategoryRepository.save(
new ReportCategoryDataBuilder().buildAsNew()
);

DashboardReport dashboardReport1 = new DashboardReportDataBuilder()
.withCategory(defaultCategory)
.withEnabled(false)
.build();
DashboardReport dashboardReport2 = new DashboardReportDataBuilder()
.withCategory(defaultCategory)
.withEnabled(false)
.build();
DashboardReport dashboardReport3 = new DashboardReportDataBuilder()
.withCategory(defaultCategory)
.build();

dashboardReportRepository.save(dashboardReport1);
dashboardReportRepository.save(dashboardReport2);
dashboardReportRepository.save(dashboardReport3);

Page<DashboardReport> page = dashboardReportRepository.findByEnabled(true, pageable);
List<DashboardReport> found = page.getContent();

assertThat(found.size(), is(1));
assertThat(page.getTotalElements(), is(1L));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,31 +22,50 @@
import static org.junit.Assert.assertThat;

import java.util.Collections;

import org.junit.Test;
import org.junit.jupiter.api.BeforeEach;
import org.openlmis.report.domain.JasperTemplate;
import org.openlmis.report.domain.JasperTemplateParameter;
import org.openlmis.report.domain.ReportCategory;
import org.springframework.beans.factory.annotation.Autowired;

public class JasperTemplateRepositoryIntegrationTest extends
BaseCrudRepositoryIntegrationTest<JasperTemplate> {

private static final String NAME = "TemplateRepositoryIntegrationTest";
private static final String CATEGORY_NAME = "Default Category";

@Autowired
private JasperTemplateRepository jasperTemplateRepository;

@Autowired
private ReportCategoryRepository reportCategoryRepository;

@Override
JasperTemplateRepository getRepository() {
return this.jasperTemplateRepository;
}

@Override
protected JasperTemplate generateInstance() {
ReportCategory category = new ReportCategory();
category.setName(CATEGORY_NAME + getNextCategoryNumber());
ReportCategory savedCategory = reportCategoryRepository.save(category);

JasperTemplate jasperTemplate = new JasperTemplate();
jasperTemplate.setName(NAME + getNextInstanceNumber());
jasperTemplate.setCategory(savedCategory);

return jasperTemplate;
}

@BeforeEach
public void setUp() {
jasperTemplateRepository.deleteAll();
reportCategoryRepository.deleteAll();
}

@Test
public void shouldFindTemplateByName() {
// given
Expand Down
Loading
Loading