Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with 24.0.0.11 Liberty runtime #1846

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Test with 24.0.0.11 Liberty runtime #1846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a039a22
Test with 24.0.0.11 Liberty runtime
cherylking Nov 19, 2024
b683d92
Update test to only look for versioned features after versionless fea…
cherylking Nov 19, 2024
2dba66b
Update another test to only look for versioned features after version…
cherylking Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
matrix:
# test against latest update of each major Java version, as well as specific updates of LTS versions:
RUNTIME: [ol, wlp]
RUNTIME_VERSION: [24.0.0.10]
RUNTIME_VERSION: [24.0.0.11]
java: [21, 17, 11, 8]
exclude:
- java: 8
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
matrix:
# test against latest update of each major Java version, as well as specific updates of LTS versions:
RUNTIME: [ol, wlp]
RUNTIME_VERSION: [24.0.0.10]
RUNTIME_VERSION: [24.0.0.11]
java: [21, 17, 11, 8]
exclude:
- java: 8
Expand Down
4 changes: 2 additions & 2 deletions ...it/src/test/java/net/wasdev/wlp/test/feature/it/InstallFeaturesVersionlessServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ public class InstallFeaturesVersionlessServerTest extends BaseInstallFeature {
@Test
public void testInstalledFeatures() throws Exception {


// as of 24.0.0.11 the versionless features no longer get reported as "installed" via productInfo command
// check for specific installed versioned features instead
assertInstalled("appSecurityClient-1.0");
assertInstalled("servlet");
assertInstalled("servlet-4.0");
assertNotInstalled("beanValidation-2.0");
assertNotInstalled("couchdb-1.0");
Expand Down
12 changes: 7 additions & 5 deletions ...ava/net/wasdev/wlp/test/feature/it/InstallFeaturesVersionlessWithVersionedServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,14 @@ public class InstallFeaturesVersionlessWithVersionedServerTest extends BaseInsta
@Test
public void testInstalledFeatures() throws Exception {


assertInstalled("beanValidation");
assertInstalled("jsp");
// as of 24.0.0.11 the versionless features no longer get reported as "installed" via productInfo command
// check for specific installed versioned features instead
assertInstalled("beanValidation-3.0");
assertInstalled("pages-3.0");
assertInstalled("enterpriseBeans-4.0");
assertInstalled("ejb");
assertInstalled("jdbc");
assertInstalled("enterpriseBeansHome-4.0");
assertInstalled("enterpriseBeansRemote-4.0");
assertInstalled("jdbc-4.2");
assertInstalled("servlet-5.0");

Set<String> expectedFeatures = new HashSet<String>();
Expand Down
Loading