Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue124 test case implemented for server.env - LCLS features #432

Open
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

SuparnaSuresh
Copy link
Contributor

@SuparnaSuresh SuparnaSuresh commented Dec 9, 2024

Fixes #437 includes
Fixes #424 , Fixes #422, Fixes #376
Automated test case implemented - server.env file

  • liberty-ls type ahead support in server.env for a Liberty Server Configuration Stanza
  • liberty-ls diagnostic support
  • liberty-ls Hover support in server.env

Copy link
Contributor

@gilbysunil14 gilbysunil14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few comments. Please check.

@SuparnaSuresh
Copy link
Contributor Author

@gilbysunil14
Incorporated the review comments. Thanks

@@ -1,3 +1,4 @@

/**
* Copyright (c) 2020, 2022 IBM Corporation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the year in copyright header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed. Thanks

@aparnamichael aparnamichael self-requested a review February 4, 2025 03:14
gilbysunil14
gilbysunil14 previously approved these changes Feb 6, 2025
Copy link
Contributor

@gilbysunil14 gilbysunil14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please check build failures.

@SuparnaSuresh
Copy link
Contributor Author

Review comments addressed. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants