-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue124 test case implemented for server.env - LCLS features #432
base: main
Are you sure you want to change the base?
Issue124 test case implemented for server.env - LCLS features #432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have few comments. Please check.
@gilbysunil14 |
src/test/definitions/constants.ts
Outdated
@@ -1,3 +1,4 @@ | |||
|
|||
/** | |||
* Copyright (c) 2020, 2022 IBM Corporation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the year in copyright header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Please check build failures.
Review comments addressed. Thanks |
Fixes #437 includes
Fixes #424 , Fixes #422, Fixes #376
Automated test case implemented - server.env file