Issue455 refresh issue due to pom generated in target on building the project #462
Conversation
src/util/helperUtil.ts
Outdated
| * @returns | ||
| */ | ||
| export function isInTargetOrBuild(filePath: string): boolean { | ||
| return filePath.includes('/target/') || filePath.includes('/build/'); |
There was a problem hiding this comment.
I don't think this is valid if it is just any "target" or "build" dir. We need to ensure the file/path is in a subdirectory of the project's "target" or "build" directory (i.e. the "target" or "build" directory located in the root project folder).
| projectProvider.refresh(); | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
I am not entirely sure about this approach, since we are still watching the "target" and "build" dirs. It would be better if we could find a way to ignore them completely.
There was a problem hiding this comment.
can we add '&&' operator in vscode.workspace.createFileSystemWatcher?
Did conditions like this work '**/pom.xml && !inside target folder' ?
There was a problem hiding this comment.
for glob patterns && operators are not available in their syntax, however negations are available as per their documentation
https://code.visualstudio.com/docs/editor/glob-patterns
There was a problem hiding this comment.
@JoshwinThomasIBM {} to group conditions (for example {**/*.pom.xml,!inside target folder} )
Can you try with this group conditions?
There was a problem hiding this comment.
@aparnamichael i tried with "/!(target)//{pom.xml,build.gradle,settings.gradle,src/main/liberty/config/server.xml}
and it seems to be working , but multiple negations is not supported in glob pattern
also with the above glob patten we expect only the one's in target to be negated and other pom's generated to be watched ,but if the the pom is generated in some other location then that is not being caught by the watcher .
…hwinThomasIBM/liberty-tools-vscode into issue455RefreshIssueDueToPom
Fixes #455
changes includes checking if the generated pom is in target /build directory within the project and if yes refresh is avoided,otherwise refresh will be executed .