Issue 481 - Green Builds Showing Despite Test Failures

src/test/resources/ci/scripts/exec.sh

@@ -26,6 +26,9 @@ currentTime=(date +"%Y/%m/%d-%H:%M:%S:%3N")
 # Operating system.
 OS=$(uname -s)
 
+# Boolean to see if any failure has occured while executing commands
+failure="false"
+
 main() {
 
     setVscodeVersionToTest
@@ -40,6 +43,7 @@ main() {
         npm run build
         npm run compile
         vsce package
+        updateExitStatus
     else
 
         #Initialisation step
@@ -66,28 +70,32 @@ main() {
                 chown -R runner src/test/resources/maven
               chown -R runner  src/test/resources/gradle
                 npm run test-mac-maven -- -u
+                updateExitStatus
                 npm run test-mac-gradle -- -u
+                updateExitStatus
             else
                 npm run test -- -u
+                updateExitStatus
             fi
         else
             # Run the plugin's install goal against the target vscode version
             if [ $OS = "Darwin" ]; then
               chown -R runner src/test/resources/maven
               chown -R runner  src/test/resources/gradle
               npm run test-mac-maven -- -u -c $VSCODE_VERSION_TO_RUN
+              updateExitStatus
               npm run test-mac-gradle -- -u -c $VSCODE_VERSION_TO_RUN
-
+              updateExitStatus
             else
             npm run test -- -u -c $VSCODE_VERSION_TO_RUN
+            updateExitStatus
             fi
         fi
     fi
 
     # If there were any errors, gather some debug data before exiting.
-    rc=$?
-    if [ "$rc" -ne 0 ]; then
-        echo "ERROR: Failure while driving npm install on plugin. rc: ${rc}."
+    if [ "$failure" = "true" ]; then
+        echo "ERROR: Failure while driving npm install on plugin."
 
         if [ $TYPE = "TEST" ]; then
             echo "DEBUG: Maven Liberty messages.log:\n"
@@ -150,4 +158,13 @@ setVscodeVersionToTest() {
         fi
 }
 
+# Finding the exit status of a command and updating failure boolean.
+# Need to call this method after executing each npm command to store the status.
+updateExitStatus() {
+    status=$?
+    if [ "$failure" = "false" ] && [ $status -ne 0 ]; then
+        failure="true"
+    fi
+}
+
 main "$@"