Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ClaRa reference file location #61

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

AnHeuermann
Copy link
Member

Changes

  • ClaRa Reference files are now available on GitHub.

@AnHeuermann AnHeuermann self-assigned this Feb 29, 2024
@AnHeuermann
Copy link
Member Author

@sjoelund do we need to remove the old /mnt/ReferenceFiles/ExtraLibs/clara_om.git/ReferenceResults from the machines manually?

Copy link
Collaborator

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnHeuermann, I wanted to have two separate tests, one for the latest released version (which can be used for OMC regression testing) and one for the HEAD/main version (which can be used for ClaRa regression testing). For some reason they now both test master, trying to figure out how with @adrpo and @sjoelund. Please keep them both

@AnHeuermann
Copy link
Member Author

Okay. But as far as I can tell all changes are now done on https://github.com/xrg-simulation/ClaRa-official.

@casella
Copy link
Collaborator

casella commented Mar 1, 2024

@AnHeuermann, @adrpo, I guess we should discuss this on Monday during the devmeeting, before we mess up 😅

@casella
Copy link
Collaborator

casella commented Mar 4, 2024

LGTM now, but there is still one issue regarding "Verify that overview.html contains simulation and verification" (whatever that means)

@casella
Copy link
Collaborator

casella commented Mar 4, 2024

Also, eventually we should try to make sure that each version that we test gets the corresponding set of reference files.

@AnHeuermann
Copy link
Member Author

Waiting for tomorrow before merging, so that the nightly tests are running again.

@adrpo adrpo merged commit cdc9f86 into OpenModelica:master Mar 4, 2024
5 checks passed
@AnHeuermann AnHeuermann deleted the update-clara branch March 5, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants