This repository has been archived by the owner on Jun 5, 2019. It is now read-only.
Add fields: {date,city} of birth, phone number #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are required fields. It would have been better to know about them in advance, but Antani. We will check for them only in JavaScript since now we have registered users. Changes in this diff: 1) added fields to oonitarian.json 2) remove unused variables (Role, RoleMapping) 3) fix first argument to autoupdate(): must be the table name (tested empirically) 4) add missing return statements in case of error 5) remove code to create default teams
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are required fields. It would have been better to know about them in advance, but Antani. We will check for them only in JavaScript since now we have registered users.
Changes in this diff:
added fields to oonitarian.json
remove unused variables (Role, RoleMapping)
fix first argument to autoupdate(): must be the table
name (tested empirically)
add missing return statements in case of error
remove code to create default teams
This is already in production in the staging system (https://ooni-adina15-staging.herokuapp.com/).