Merge pull request #172 from OpenPEPPOL/POACC-824

Poacc 824
OpenPEPPOL · Feb 20, 2025 · 2b0cc84 · 2b0cc84
2 parents 3c3d2fa + f9edb67
commit 2b0cc84
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 14 deletions.
diff --git a/guide/release-notes/v3.0.19.adoc b/guide/release-notes/v3.0.19.adoc
@@ -10,6 +10,7 @@ Release date:: May 2025
 == Changes to code lists and validation artefacts
 
 * BUG Missing currencyID check for BT-117 in Peppol BIS Billing 3.0 PEPPOL-EN16931-R051 [minor]
+* Rule PEPPOL-COMMON-R042 which tests danish organization numbers, CVR, (ICD 0184) is updated according to the Participant identifier schemes codelists. The identifier must be 8 characters long and no longer prefixed with DK.
 
 ==  EN 16931 schematrons updated
 

diff --git a/rules/examples/vat-category-E.xml b/rules/examples/vat-category-E.xml
@@ -37,7 +37,7 @@
     </cac:AccountingSupplierParty>
     <cac:AccountingCustomerParty>
         <cac:Party>
-            <cbc:EndpointID schemeID="0184">DK12345678</cbc:EndpointID>
+            <cbc:EndpointID schemeID="0184">12345678</cbc:EndpointID>
             <cac:PostalAddress>
                 <cbc:StreetName>Anystreet 8</cbc:StreetName>
                 <cbc:AdditionalStreetName>Back door</cbc:AdditionalStreetName>

diff --git a/rules/examples/vat-category-Z.xml b/rules/examples/vat-category-Z.xml
@@ -37,7 +37,7 @@
     </cac:AccountingSupplierParty>
     <cac:AccountingCustomerParty>
         <cac:Party>
-            <cbc:EndpointID schemeID="0184">DK12345678</cbc:EndpointID>
+            <cbc:EndpointID schemeID="0184">12345678</cbc:EndpointID>
             <cac:PostalAddress>
                 <cbc:StreetName>Anystreet 8</cbc:StreetName>
                 <cbc:AdditionalStreetName>Back door</cbc:AdditionalStreetName>

diff --git a/rules/sch/PEPPOL-EN16931-CII.sch b/rules/sch/PEPPOL-EN16931-CII.sch
@@ -311,7 +311,7 @@ Last update: 2024 May release 3.0.17.
       <assert id="PEPPOL-COMMON-R041" test="matches(normalize-space(), '^[0-9]{9}$') and u:mod11(normalize-space())" flag="fatal">Norwegian organization number MUST be stated in the correct format.</assert>
     </rule>
     <rule context="ram:URIID[@schemeID = '0184'] | ram:ID[@schemeID = '0184'] | ram:GlobalID[@schemeID = '0184']">
-      <assert id="PEPPOL-COMMON-R042" test="(string-length(text()) = 10) and (substring(text(), 1, 2) = 'DK') and (string-length(translate(substring(text(), 3, 8), '1234567890', '')) = 0)" flag="fatal">Danish organization number (CVR) MUST be stated in the correct format.</assert>
+      <assert id="PEPPOL-COMMON-R042" test="(string-length(text()) = 8) and (string-length(translate(substring(text(), 1, 8), '1234567890', '')) = 0)" flag="fatal">Danish organization number (CVR) MUST be stated in the correct format.</assert>
     </rule>
     <rule context="ram:URIID[@schemeID = '0208'] | ram:ID[@schemeID = '0208'] | ram:GlobalID[@schemeID = '0208']">
       <assert id="PEPPOL-COMMON-R043" test="matches(normalize-space(), '^[0-9]{10}$') and u:mod97-0208(normalize-space())" flag="fatal">Belgian enterprise number MUST be stated in the correct format.</assert>

diff --git a/rules/sch/PEPPOL-EN16931-UBL.sch b/rules/sch/PEPPOL-EN16931-UBL.sch
@@ -445,7 +445,7 @@ Last update: 2024 November release 3.0.18.
     <rule
       context="cbc:EndpointID[@schemeID = '0184'] | cac:PartyIdentification/cbc:ID[@schemeID = '0184'] | cbc:CompanyID[@schemeID = '0184']">
       <assert id="PEPPOL-COMMON-R042"
-        test="(string-length(text()) = 10) and (substring(text(), 1, 2) = 'DK') and (string-length(translate(substring(text(), 3, 8), '1234567890', '')) = 0)"
+        test="(string-length(text()) = 8) and (string-length(translate(substring(text(), 1, 8), '1234567890', '')) = 0)"
         flag="fatal">Danish organization number (CVR) MUST be stated in the correct format.</assert>
     </rule>
     <rule

diff --git a/rules/unit-CII-PEPPOL/PEPPOL-COMMON-R042.xml b/rules/unit-CII-PEPPOL/PEPPOL-COMMON-R042.xml
@@ -53,12 +53,12 @@
 				<ram:ApplicableHeaderTradeAgreement>
 					<ram:SellerTradeParty>
 						<ram:SpecifiedLegalOrganization>
-							<ram:ID schemeID="0184">DK12345678</ram:ID>
+							<ram:ID schemeID="0184">12345678</ram:ID>
 						</ram:SpecifiedLegalOrganization>
 					</ram:SellerTradeParty>
 					<ram:BuyerTradeParty>
 						<ram:SpecifiedLegalOrganization>
-							<ram:ID schemeID="0184">DK12345679</ram:ID>
+							<ram:ID schemeID="0184">12345679</ram:ID>
 						</ram:SpecifiedLegalOrganization>
 					</ram:BuyerTradeParty>
 				</ram:ApplicableHeaderTradeAgreement>
@@ -87,7 +87,7 @@
 					</ram:SellerTradeParty>
 					<ram:BuyerTradeParty>
 						<ram:SpecifiedLegalOrganization>
-							<ram:ID schemeID="0184">DK12345678</ram:ID>
+							<ram:ID schemeID="0184">12345678</ram:ID>
 						</ram:SpecifiedLegalOrganization>
 					</ram:BuyerTradeParty>
 				</ram:ApplicableHeaderTradeAgreement>
@@ -116,7 +116,7 @@
 					</ram:SellerTradeParty>
 					<ram:BuyerTradeParty>
 						<ram:SpecifiedLegalOrganization>
-							<ram:ID schemeID="0184">DK123456789</ram:ID>
+							<ram:ID schemeID="0184">12345678</ram:ID>
 						</ram:SpecifiedLegalOrganization>
 					</ram:BuyerTradeParty>
 				</ram:ApplicableHeaderTradeAgreement>

diff --git a/rules/unit-UBL-PEPPOL/PEPPOL-COMMON-R042.xml b/rules/unit-UBL-PEPPOL/PEPPOL-COMMON-R042.xml
@@ -14,7 +14,7 @@
 				<cac:Party>
 					<cac:PartyLegalEntity>
 						<cbc:RegistrationName>Customer A A/S</cbc:RegistrationName>
-						<cbc:CompanyID schemeID="0184">DK12345678</cbc:CompanyID>
+						<cbc:CompanyID schemeID="0184">12345678</cbc:CompanyID>
 					</cac:PartyLegalEntity>
 				</cac:Party>
 			</cac:AccountingCustomerParty>
@@ -30,7 +30,7 @@
 				<cac:Party>
 					<cac:PartyLegalEntity>
 						<cbc:RegistrationName>Supplier A/S</cbc:RegistrationName>
-						<cbc:CompanyID schemeID="0184">DK12345678</cbc:CompanyID>
+						<cbc:CompanyID schemeID="0184">12345678</cbc:CompanyID>
 					</cac:PartyLegalEntity>
 				</cac:Party>
 			</cac:AccountingSupplierParty>
@@ -46,7 +46,7 @@
 				<cac:Party>
 					<cac:PartyLegalEntity>
 						<cbc:RegistrationName>Customer A A/S</cbc:RegistrationName>
-						<cbc:CompanyID schemeID="0184">DK12345678</cbc:CompanyID>
+						<cbc:CompanyID schemeID="0184">12345678</cbc:CompanyID>
 					</cac:PartyLegalEntity>
 				</cac:Party>
 			</cac:AccountingCustomerParty>
@@ -62,7 +62,7 @@
 				<cac:Party>
 					<cac:PartyLegalEntity>
 						<cbc:RegistrationName>Supplier A/S</cbc:RegistrationName>
-						<cbc:CompanyID schemeID="0184">DK12345678</cbc:CompanyID>
+						<cbc:CompanyID schemeID="0184">12345678</cbc:CompanyID>
 					</cac:PartyLegalEntity>
 				</cac:Party>
 			</cac:AccountingSupplierParty>
@@ -96,7 +96,7 @@
 				<cac:Party>
 					<cac:PartyLegalEntity>
 						<cbc:RegistrationName>Customer A A/S</cbc:RegistrationName>
-						<cbc:CompanyID schemeID="0184">DK-12345678</cbc:CompanyID>
+						<cbc:CompanyID schemeID="0184">DK12345678</cbc:CompanyID>
 					</cac:PartyLegalEntity>
 				</cac:Party>
 			</cac:AccountingCustomerParty>
@@ -112,7 +112,7 @@
 				<cac:Party>
 					<cac:PartyLegalEntity>
 						<cbc:RegistrationName>Supplier A/S</cbc:RegistrationName>
-						<cbc:CompanyID schemeID="0184">12345678</cbc:CompanyID>
+						<cbc:CompanyID schemeID="0184">345678</cbc:CompanyID>
 					</cac:PartyLegalEntity>
 				</cac:Party>
 			</cac:AccountingSupplierParty>