Updated ModSDK scripts from various old versions to release-20200503 #777
Conversation
|
These files are no longer used and can also be deleted:
|
There was a problem hiding this comment.
The SDK has the following files commited with unix line endings, it would be good IMO to change them here to match:
launch-game.cmd
make.ps1
packaging/windows/buildpackage.nsi
utility.cmd
packaging/linux/buildpackage.sh is also missing its end-of-file newline.
|
LGTM otherwise; there are some wording changes and a couple of other differences where the SDK is wrong, but if it isn't a goal to directly use the SDK files then that isn't an issue. |
Updated `launch-dedicated.cmd` and `launch-dedicated.sh` based on:
- ModSDK PR 145 - "Update engine for playtest-2020030" ("Add missing launch arguments to launch-dedicated scripts.").
- ModSDK PR 155 - "Update for playtest-20200418".
Updated `mod.config` based on ModSDK PR 150 - "Update to playtest-20200329".
Updated `buildpackage.nsi` based on ModSDK PR 155 - "Update for playtest-20200418".
Removed spurious *.dll.config files from `packaging/linux/include` based on ModSDK PR 117 - "Update scripts to work with the new engine toolchain.".
penev92
force-pushed
the
updateModSdkTo20200503
branch
from
62c3e72 to
a43d65f
Compare
|
Removed old files
and fixed indentation error in If you see any other discrepencies between this and https://github.com/OpenRA/OpenRAModSDK/tree/20200503 please be specific, as there are some intentional ones where the RA2 scripts have modified messages. There are also a few points where the ModSDK scripts may need fixing upstream, but since this is an old version of the ModSDK I've just skipped past that. Also if someone not on Windows can handle the EoL thing (preferably at a later point when we're done because there are also issues inside the custom code) that would be great. |
|
Added @pchote's commit to fix files for unix standards and added some missing artwork (used placeholders from the ModSDK example). |
This is an attempt to supersede #764 and update the mod to the current release (
release-20210321). This will be followed by3 other PRsanother PR that will updatethings in pieceseverything (SDK scripts, engine/custom code and mod rules) fromrelease-20200503torelease-20210321. See commit messages for detailed explanations.We are starting off small because some of the SDK scripts were quite outdated and this seems like low-hanging fruit.