This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
Nhse o32 orkv.i58 backport #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimisations: - Take the timestamp to the cache after get_stats/0 has returned, so that if get_stats/0 takes > 1s any requests in the queue for riak_kv_http_cache will still use the cache. - refactor riak_kv_status:aliases/0 to use simple lists rather than orddict. - remove altogether the sys_monitor_count, it is simply too expensive. Available as a riak_kv_util module function instead for the experienced operator.
It takes more than 5s on some systems at the moment - and this then dumps an unhelpful crashdump to the user. Make a longer default timeout, allow the timeout to be passed by the operator, and also return more operator-friendly error on timeout occurring.
|
This removes a statistic in a minor version release. I think this is acceptable, but will include a specific warning in the release notes and other release announcements. I prefer this to including a dummy statistic which may be misleading. |
ThomasArts
approved these changes
Jan 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring https://github.com/OpenRiak/riak_kv/pull/59 to 3.2.
Test also backported - https://github.com/OpenRiak/riak_test/pull/36