RHEL8 mode and backup jobs #64
Conversation
ansible/workers.yml
Outdated
| @@ -25,6 +33,7 @@ | |||
| key: "{{ lookup('file', 'generated_bits/master_id_rsa.pub') }}" | |||
| exclusive: yes # only need one key for "jenkins" user, users can still connect as ec2-user | |||
| state: present | |||
| when: False | |||
ansible/workers.yml
Outdated
| name: | ||
| - PyYAML # needed for the new SSG yaml port | ||
| state: installed | ||
| when: ansible_distribution != 'RedHat' or ansible_distribution_version.split(".")[0] != "8" |
There was a problem hiding this comment.
Is assume this task RHEL8 only, as next task is Fedora only.
So shouldn't this be ansible_distribution == 'RedHat' and ansible_distribution_version.split(".")[0] != "8"?
ansible/workers.yml
Outdated
| state: installed | ||
| when: ansible_distribution == 'Fedora' or (ansible_distribution == 'RedHat' and ansible_distribution_version.split(".")[0] == "8") | ||
|
|
||
| - name: Ensure OpenSCAP Anaconda dependencies are installed (Fedora only) |
There was a problem hiding this comment.
I would change name of task to explicitly mention zanata.
It is confusing as it is now, because there is two tasks with same name, one Fedora and RHEL8 only, and the other Fedora only.
There was a problem hiding this comment.
I see that we install the Zanata Python client for RHEL7 and for Fedora, but not for RHEL8. Is this expected?
There was a problem hiding this comment.
@matejak yum search zanata doesn't find anything on our RHEL 8 worker
I have fixed the RHEL 8 node and then I tried to reflect the changes on the node in our Playbook. But I don't know how to generate a Playbook from a node, so I have updated the Playbook manually. Also, I have enabled RHEL 8 node in some jobs. I backup the jobs configuration to the git repository.
|
I have run |
|
LGTM. Note: Please backup new rhel8 jobs from jenkins and include missing jobs into |
|
@yuumasato PR author has addressed requested modifications and tests. Merging PR |
I have fixed the RHEL 8 node and then I tried to reflect the
changes on the node in our Playbook. But I don't know how
to generate a Playbook from a node, so I have updated the Playbook
manually. Also, I have enabled RHEL 8 node in some jobs.
I backup the jobs configuration to the git repository.