Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build OpenSCAP with clang sanitizers #1970

Closed
wants to merge 1 commit into from

Conversation

jan-cerny
Copy link
Member

@jan-cerny jan-cerny commented May 10, 2023

This PR will create a special COPR build where OpenSCAP will be built with the Clang compiler with special options.

The special option is a ThreadSanitizer https://clang.llvm.org/docs/ThreadSanitizer.html is a tool that detects data races.

This way we will be able to use and download the build and use it instead of normal OpenSCAP package to debug issues like freezing or thread crashes. The oscap will work as usual but at the same time it will print warnings when a data race happens.

To get meaningful warnings you should install also the openscap-debuginfo rpm package, you will get tracebacks with exact file names and line numbers of the problematic code.

I propose creating COPR builds for EPEL 8 and 9.

@jan-cerny jan-cerny force-pushed the clang branch 21 times, most recently from 24a4bbd to 73d8ad0 Compare May 11, 2023 09:20
@jan-cerny jan-cerny changed the title [do not merge] Build OpenSCAP with clang sanitizers Build OpenSCAP with clang sanitizers May 11, 2023
targets:
- fedora-all-x86_64
- centos-stream-8-x86_64
- centos-stream-9-x86_64

- job: tests
trigger: pull_request
Copy link

@lachmanfrantisek lachmanfrantisek May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
trigger: pull_request
trigger: pull_request
identifier: standard

This is probably what makes the mess in the statuses.

@maage
Copy link
Contributor

maage commented May 12, 2023

I modified my spec to have a part of sanitizers I hope are also in scope here, #1883

@jan-cerny
Copy link
Member Author

I wasn't able to configure Packit to not create "unwanted" builds and test runs. It seems to combine the build targets together.

It would be possible to avoid this situation if Packit had an option to define build-test dependencies explicitely, see packit/packit-service#1720.

@jan-cerny jan-cerny closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants