set_t while free_cell callbacks are running #3500
Closed
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates here? No progress has been made in the last 30 days, marking as stale. |
|
Any updates here? No progress has been made in the last 30 days, marking as stale. |
|
Any updates here? No progress has been made in the last 30 days, marking as stale. |
|
@vladpaiu , thanks for the work here. IMHO, in regards to the #3498 issue, the fix should not be setting a new T while running the destroy callbacks (there is no need for the value), but rather to be sure the T is cleaned up at the end of any previous processing. Some TM code is "leaking" the T value.... and fixing this leaking should be the proper approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Potential fix for #3498
Details
Potential fix for #3498
Solution
set_t while free_cell callbacks are running
Compatibility
Should be compatible
Closing issues