Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reasoner): support value type inference in udf #132

Merged
merged 9 commits into from
Mar 5, 2024
Merged

Conversation

fishjoy
Copy link
Collaborator

@fishjoy fishjoy commented Mar 1, 2024

No description provided.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 62.43094% with 68 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@eb2590a). Click here to learn what that means.

Files Patch % Lines
...group/openspg/reasoner/lube/logical/ExprUtil.scala 44.00% 19 Missing and 23 partials ⚠️
...nspg/reasoner/rdg/common/KgGraphAggregateImpl.java 65.38% 8 Missing and 1 partial ⚠️
...easoner/lube/logical/planning/ProjectPlanner.scala 55.55% 3 Missing and 5 partials ⚠️
...ner/lube/logical/planning/AggregationPlanner.scala 62.50% 2 Missing and 4 partials ⚠️
...ntgroup/openspg/reasoner/common/types/KgType.scala 66.66% 1 Missing and 1 partial ⚠️
...p/openspg/reasoner/lube/common/rule/RuleImpl.scala 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #132   +/-   ##
=========================================
  Coverage          ?   51.17%           
  Complexity        ?      260           
=========================================
  Files             ?      654           
  Lines             ?    22381           
  Branches          ?     3710           
=========================================
  Hits              ?    11454           
  Misses            ?     9551           
  Partials          ?     1376           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

import java.util.List;
import java.util.Map;

public interface UdfMng {
public interface UdfMng extends Serializable {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is not allowed to be serialized as it contains a Java Method Object internally.
you can call UdfMngFactory.getUdfMng to retrieve an instance

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

This class is not allowed to be serialized as it contains a Java Method Object internally. you can call UdfMngFactory.getUdfMng to retrieve an instance

Copy link
Collaborator

@youdonghai youdonghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@royzhao royzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fishjoy fishjoy merged commit 258b0e7 into master Mar 5, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants