Fix for Windows 11 Audio Lag #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult). Win 11 seems to use a much larger value.
… default to 512. Also, adding some debugging output. This will allow users to override the default audio buffer size, to better customize for their system.
…ames in OpenShot always begin with 1 (not 0)
…. Should be equivalent to Qt::SkipEmptyParts.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #983 +/- ##
===========================================
- Coverage 54.84% 54.80% -0.04%
===========================================
Files 182 182
Lines 16638 16656 +18
===========================================
+ Hits 9125 9129 +4
- Misses 7513 7527 +14 ☔ View full report in Codecov by Sentry. |
|
This PR requires changes from libopenshot-audio to build correctly. I'm going to go ahead and merge, as it should be fine. Famous last words, lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting default audio buffer size on Audio Device Manager to 512, to resolve issue on Windows 11 (and some users Windows 10). Newer versions of Windows seem to request 2500 ish audio samples per callback, instead of the 512 requested by Linux. This increase in buffer size causes libopenshot to decode many more frames than normal, causing a 1 to 2 second lag before hearing any audio playback on the OS.
This is also building against our new version of libopenshot-audio, which as been upgraded to JUCE 7.0.10, and now uses C++ standard 17, and targets Mac OS 10.12 (changed from 10.9).