Remove filters #101
Merged
Remove filters #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
hmgaudecker
reviewed
Feb 4, 2025
| @@ -213,31 +140,19 @@ def _segment_logsumexp(a, segment_info): | |||
| def _determine_dense_discrete_choice_axes( | |||
There was a problem hiding this comment.
Suggested change
| def _determine_dense_discrete_choice_axes( | |
| def _determine_discrete_choice_axes( |
Not sure whether getting rid of dense terminology is out-of-scope for this PR or not. But might add clarity.
There was a problem hiding this comment.
I would say it is out-of-scope. The problem is that we still need --what we currently call sparse variables-- for the simulation. I would like to avoid a state of the code-base where we have "variables" and "sparse variables" to avoid confusion. In the upcoming renaming/refactoring PR I am planning to give these two concepts better fitting names.
hmgaudecker
approved these changes
Feb 4, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we remove filters from the code-base.
We remove filters and related code from the code-base without starting a major refactoring. This will be done in a separate PR.
Note
Sparse variables are still required in the simulation; however, no filters are needed and only state variables can be sparse not choices. I will think about a better name for "sparse" variables in this context in the next PRs.
ToDo in next PR's
Refactoring and Renaming
_determine_dense_discrete_choice_axesdiscrete_problem._determine_dense_discrete_choice_axesandsimulate.determine_discrete_dense_choice_axes: They look similar, and do similar things, but not exactly -> Combine these with an argument likepurpose: Literal["solution", "simulation"].