Fix bug with !solve dropping additional solvers
#226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
approved these changes
Jun 6, 2020
!solve drops the first additional solver when called from within the challenge channel. This patch fixes that. + Tighten up the logic related to identifying the current channel + Prevent solves from occurring outside of a ctf/challenge channel Incorporate PR feedback from grazfather Remove an entire level of indentation by throwing immediately upon challenge being set to None. Incorporate PR feedback from kileak + Revert changes made in b88b8cc to the util function `get_challenge_from_args` + Add method `get_challenge_by_args_or_channel` for tag commands The bug in the `!solve` command was introduced as a result of the utility function changes that are undone here, fixing the bug. Fix typo
l4cr0ss
force-pushed
the
fix_solve_dropping_addtl_solvers
branch
from
75bc605 to
9dfb731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
!solvecommand is currently dropping the first additional solver, if present, when the command is called from within the challenge channel. It's working as expected in all other invocation contexts. See screenshot below.Incorrect - drops first additional solver
Incorrect - drops first and keeps second additional solver
Correct - called from within CTF channel, retains first additional solver
Correct - called from within CTF channel, retains first and second additional solvers
Solution
This patch corrects a logic error causing the first arg to be sliced off when !solve is called from within a challenge channel.
Corrected scenarios
