This repository has been archived by the owner on Oct 24, 2021. It is now read-only.
patch/remove skill api #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
force-pushed
the
ptch/remove_skill_api
branch
from
1ceb9ce to
eff21d1
Compare
JarbasAl
commented
Mar 6, 2021
| @@ -490,8 +434,7 @@ def voc_match(self, utt, voc_filename, lang=None, exact=False): | |||
| voc_filename + '.voc')) | |||
|
|
|||
| if not voc or not exists(voc): | |||
| raise FileNotFoundError( | |||
| 'Could not find {}.voc file'.format(voc_filename)) | |||
| return False | |||
There was a problem hiding this comment.
this was an unrelated fix not meant to be in this PR
if the voc file does not exist this now returns False instead of throwing an exception, if the file does not exist the voc doesnt match, no reason to fail the intent
log also removed because it can be very spammy
this is particularly useful in the skill templates, change was done due to issues found when working on #49
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove patch for MycroftAI/mycroft-core#1822 which has been merged upstream