Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Sn Foundry test utils #1085

Merged
merged 33 commits into from
Aug 8, 2024
Merged

Conversation

immrsd
Copy link
Collaborator

@immrsd immrsd commented Aug 6, 2024

Addresses #1072

Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I left some comments and questions

docs/modules/ROOT/pages/api/test_utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/test_utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/test_utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/test_utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/test_utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/test_utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/test_utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/test_utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/api/test_utilities.adoc Outdated Show resolved Hide resolved
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @immrsd. I left a small suggestion (plus the andrew's comments), being the most important one the header sections fix to show the sidebar.

docs/modules/ROOT/pages/api/test_utilities.adoc Outdated Show resolved Hide resolved
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @immrsd. Left a small suggestion. Looks good to me otherwise!

docs/modules/ROOT/pages/api/testing.adoc Outdated Show resolved Hide resolved
@ericnordelo ericnordelo merged commit c2c1b41 into OpenZeppelin:main Aug 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants